From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78344C433E3 for ; Tue, 28 Jul 2020 12:07:25 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B5692070B for ; Tue, 28 Jul 2020 12:07:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B5692070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 1D7408788D; Tue, 28 Jul 2020 12:07:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uxEU-GB45pqE; Tue, 28 Jul 2020 12:07:24 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 91DC286D73; Tue, 28 Jul 2020 12:07:24 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 65212C004F; Tue, 28 Jul 2020 12:07:24 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 150B1C004D for ; Tue, 28 Jul 2020 12:07:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 10CAF86CC7 for ; Tue, 28 Jul 2020 12:07:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tlD7ga7lKM6p for ; Tue, 28 Jul 2020 12:07:22 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by whitealder.osuosl.org (Postfix) with ESMTPS id 718EE86CC5 for ; Tue, 28 Jul 2020 12:07:22 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 422D468B05; Tue, 28 Jul 2020 14:07:17 +0200 (CEST) Date: Tue, 28 Jul 2020 14:07:16 +0200 From: Christoph Hellwig To: Amit Pundir Subject: Re: dma-pool fixes Message-ID: <20200728120716.GA2507@lst.de> References: <20200728104742.422960-1-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: jeremy.linton@arm.com, iommu@lists.linux-foundation.org, linux-rpi-kernel@lists.infradead.org, David Rientjes , Robin Murphy , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Jul 28, 2020 at 05:32:56PM +0530, Amit Pundir wrote: > > can you try these two patches? The first one makes sure we don't apply > > physical address based checks for IOMMU allocations, and the second one > > is a slightly tweaked version of the patch from Nicolas to allow dipping > > into the CMA areas for allocations to expand the atomic pools. > > Sorry, verified a couple of times but these two patches are not working > for me. I'm stuck at the bootloader splash screen on my phone. Thanks for testing. The only intended functional change compared to Fridays patch was the issue Nicolas pointed out. Can you try this hack on top? diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c index 83fda10394937b..88e40a022b6bfd 100644 --- a/kernel/dma/pool.c +++ b/kernel/dma/pool.c @@ -70,13 +70,14 @@ static bool cma_in_zone(gfp_t gfp) size = cma_get_size(cma); if (!size) return false; - +#if 0 /* CMA can't cross zone boundaries, see cma_activate_area() */ end = cma_get_base(cma) - memblock_start_of_DRAM() + size - 1; if (IS_ENABLED(CONFIG_ZONE_DMA) && (gfp & GFP_DMA)) return end <= DMA_BIT_MASK(zone_dma_bits); if (IS_ENABLED(CONFIG_ZONE_DMA32) && (gfp & GFP_DMA32)) return end <= DMA_BIT_MASK(32); +#endif return true; } _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu