* [PATCH 2/3] iommu: intel: Drop kerneldoc marker from regular comment
2020-07-28 17:08 [PATCH 1/3] iommu: amd: Fix kerneldoc Krzysztof Kozlowski
@ 2020-07-28 17:08 ` Krzysztof Kozlowski
2020-09-04 14:56 ` Bjorn Andersson
2020-07-28 17:08 ` [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-28 17:08 UTC (permalink / raw)
To: Joerg Roedel, David Woodhouse, Lu Baolu, Rob Clark, Andy Gross,
Bjorn Andersson, iommu, linux-kernel, linux-arm-msm
Cc: Krzysztof Kozlowski
Fix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/intel/dmar.c:389: warning: Function parameter or member 'header' not described in 'dmar_parse_one_drhd'
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/iommu/intel/dmar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
index 93e6345f3414..ba47edf03941 100644
--- a/drivers/iommu/intel/dmar.c
+++ b/drivers/iommu/intel/dmar.c
@@ -380,7 +380,7 @@ dmar_find_dmaru(struct acpi_dmar_hardware_unit *drhd)
return NULL;
}
-/**
+/*
* dmar_parse_one_drhd - parses exactly one DMA remapping hardware definition
* structure which uniquely represent one DMA remapping hardware unit
* present in the platform
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/3] iommu: intel: Drop kerneldoc marker from regular comment
2020-07-28 17:08 ` [PATCH 2/3] iommu: intel: Drop kerneldoc marker from regular comment Krzysztof Kozlowski
@ 2020-09-04 14:56 ` Bjorn Andersson
0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2020-09-04 14:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-msm, iommu, linux-kernel, Andy Gross, David Woodhouse
On Tue 28 Jul 12:08 CDT 2020, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
>
> drivers/iommu/intel/dmar.c:389: warning: Function parameter or member 'header' not described in 'dmar_parse_one_drhd'
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/iommu/intel/dmar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
> index 93e6345f3414..ba47edf03941 100644
> --- a/drivers/iommu/intel/dmar.c
> +++ b/drivers/iommu/intel/dmar.c
> @@ -380,7 +380,7 @@ dmar_find_dmaru(struct acpi_dmar_hardware_unit *drhd)
> return NULL;
> }
>
> -/**
> +/*
> * dmar_parse_one_drhd - parses exactly one DMA remapping hardware definition
> * structure which uniquely represent one DMA remapping hardware unit
> * present in the platform
> --
> 2.17.1
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable
2020-07-28 17:08 [PATCH 1/3] iommu: amd: Fix kerneldoc Krzysztof Kozlowski
2020-07-28 17:08 ` [PATCH 2/3] iommu: intel: Drop kerneldoc marker from regular comment Krzysztof Kozlowski
@ 2020-07-28 17:08 ` Krzysztof Kozlowski
2020-09-04 14:56 ` Bjorn Andersson
2020-09-04 8:57 ` [PATCH 1/3] iommu: amd: Fix kerneldoc Joerg Roedel
2020-09-04 14:57 ` Bjorn Andersson
3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-28 17:08 UTC (permalink / raw)
To: Joerg Roedel, David Woodhouse, Lu Baolu, Rob Clark, Andy Gross,
Bjorn Andersson, iommu, linux-kernel, linux-arm-msm
Cc: Krzysztof Kozlowski
The of_device_id is included unconditionally by of.h header and used
in the driver as well. Remove of_match_ptr to fix W=1 compile test
warning with !CONFIG_OF:
drivers/iommu/qcom_iommu.c:910:34: warning: 'qcom_iommu_of_match' defined but not used [-Wunused-const-variable=]
910 | static const struct of_device_id qcom_iommu_of_match[] = {
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/iommu/qcom_iommu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
index af6bec3ace00..9535a6af7553 100644
--- a/drivers/iommu/qcom_iommu.c
+++ b/drivers/iommu/qcom_iommu.c
@@ -752,7 +752,7 @@ static const struct of_device_id ctx_of_match[] = {
static struct platform_driver qcom_iommu_ctx_driver = {
.driver = {
.name = "qcom-iommu-ctx",
- .of_match_table = of_match_ptr(ctx_of_match),
+ .of_match_table = ctx_of_match,
},
.probe = qcom_iommu_ctx_probe,
.remove = qcom_iommu_ctx_remove,
@@ -915,7 +915,7 @@ static const struct of_device_id qcom_iommu_of_match[] = {
static struct platform_driver qcom_iommu_driver = {
.driver = {
.name = "qcom-iommu",
- .of_match_table = of_match_ptr(qcom_iommu_of_match),
+ .of_match_table = qcom_iommu_of_match,
.pm = &qcom_iommu_pm_ops,
},
.probe = qcom_iommu_device_probe,
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable
2020-07-28 17:08 ` [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
@ 2020-09-04 14:56 ` Bjorn Andersson
0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2020-09-04 14:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-msm, iommu, linux-kernel, Andy Gross, David Woodhouse
On Tue 28 Jul 12:08 CDT 2020, Krzysztof Kozlowski wrote:
> The of_device_id is included unconditionally by of.h header and used
> in the driver as well. Remove of_match_ptr to fix W=1 compile test
> warning with !CONFIG_OF:
>
> drivers/iommu/qcom_iommu.c:910:34: warning: 'qcom_iommu_of_match' defined but not used [-Wunused-const-variable=]
> 910 | static const struct of_device_id qcom_iommu_of_match[] = {
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/iommu/qcom_iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
> index af6bec3ace00..9535a6af7553 100644
> --- a/drivers/iommu/qcom_iommu.c
> +++ b/drivers/iommu/qcom_iommu.c
> @@ -752,7 +752,7 @@ static const struct of_device_id ctx_of_match[] = {
> static struct platform_driver qcom_iommu_ctx_driver = {
> .driver = {
> .name = "qcom-iommu-ctx",
> - .of_match_table = of_match_ptr(ctx_of_match),
> + .of_match_table = ctx_of_match,
> },
> .probe = qcom_iommu_ctx_probe,
> .remove = qcom_iommu_ctx_remove,
> @@ -915,7 +915,7 @@ static const struct of_device_id qcom_iommu_of_match[] = {
> static struct platform_driver qcom_iommu_driver = {
> .driver = {
> .name = "qcom-iommu",
> - .of_match_table = of_match_ptr(qcom_iommu_of_match),
> + .of_match_table = qcom_iommu_of_match,
> .pm = &qcom_iommu_pm_ops,
> },
> .probe = qcom_iommu_device_probe,
> --
> 2.17.1
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] iommu: amd: Fix kerneldoc
2020-07-28 17:08 [PATCH 1/3] iommu: amd: Fix kerneldoc Krzysztof Kozlowski
2020-07-28 17:08 ` [PATCH 2/3] iommu: intel: Drop kerneldoc marker from regular comment Krzysztof Kozlowski
2020-07-28 17:08 ` [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
@ 2020-09-04 8:57 ` Joerg Roedel
2020-09-04 14:57 ` Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: Joerg Roedel @ 2020-09-04 8:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, iommu, Andy Gross, linux-arm-msm, David Woodhouse
On Tue, Jul 28, 2020 at 07:08:57PM +0200, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
>
> drivers/iommu/amd/init.c:1586: warning: Function parameter or member 'ivrs' not described in 'get_highest_supported_ivhd_type'
> drivers/iommu/amd/init.c:1938: warning: Function parameter or member 'iommu' not described in 'iommu_update_intcapxt'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/iommu/amd/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied all 3, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] iommu: amd: Fix kerneldoc
2020-07-28 17:08 [PATCH 1/3] iommu: amd: Fix kerneldoc Krzysztof Kozlowski
` (2 preceding siblings ...)
2020-09-04 8:57 ` [PATCH 1/3] iommu: amd: Fix kerneldoc Joerg Roedel
@ 2020-09-04 14:57 ` Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2020-09-04 14:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-arm-msm, iommu, linux-kernel, Andy Gross, David Woodhouse
On Tue 28 Jul 12:08 CDT 2020, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
>
> drivers/iommu/amd/init.c:1586: warning: Function parameter or member 'ivrs' not described in 'get_highest_supported_ivhd_type'
> drivers/iommu/amd/init.c:1938: warning: Function parameter or member 'iommu' not described in 'iommu_update_intcapxt'
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/iommu/amd/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index 958050c213f9..4a37169b1b1b 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -1578,7 +1578,7 @@ static int __init init_iommu_one(struct amd_iommu *iommu, struct ivhd_header *h)
>
> /**
> * get_highest_supported_ivhd_type - Look up the appropriate IVHD type
> - * @ivrs Pointer to the IVRS header
> + * @ivrs: Pointer to the IVRS header
> *
> * This function search through all IVDB of the maximum supported IVHD
> */
> @@ -1929,7 +1929,7 @@ static int iommu_setup_msi(struct amd_iommu *iommu)
> #define XT_INT_VEC(x) (((x) & 0xFFULL) << 32)
> #define XT_INT_DEST_HI(x) ((((x) >> 24) & 0xFFULL) << 56)
>
> -/**
> +/*
> * Setup the IntCapXT registers with interrupt routing information
> * based on the PCI MSI capability block registers, accessed via
> * MMIO MSI address low/hi and MSI data registers.
> --
> 2.17.1
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 7+ messages in thread