From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB369C43463 for ; Fri, 18 Sep 2020 09:31:27 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50BA921582 for ; Fri, 18 Sep 2020 09:31:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50BA921582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id CF424872DC; Fri, 18 Sep 2020 09:31:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g7vspIycg8R0; Fri, 18 Sep 2020 09:31:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 63A66872D0; Fri, 18 Sep 2020 09:31:26 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3649AC0859; Fri, 18 Sep 2020 09:31:26 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7C2D0C0051 for ; Fri, 18 Sep 2020 09:31:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 7104187657 for ; Fri, 18 Sep 2020 09:31:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j4LiP8fc+VHw for ; Fri, 18 Sep 2020 09:31:22 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by hemlock.osuosl.org (Postfix) with ESMTPS id 0B9668764D for ; Fri, 18 Sep 2020 09:31:21 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 764C2293; Fri, 18 Sep 2020 11:31:19 +0200 (CEST) Date: Fri, 18 Sep 2020 11:31:18 +0200 From: Joerg Roedel To: Suravee Suthikulpanit Subject: Re: [PATCH 2/3] iommu: amd: Add support for RMP_PAGE_FAULT and RMP_HW_ERR Message-ID: <20200918093117.GO31590@8bytes.org> References: <20200916135549.146468-1-suravee.suthikulpanit@amd.com> <20200916135549.146468-3-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200916135549.146468-3-suravee.suthikulpanit@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, Jon.Grimm@amd.com, brijesh.singh@amd.com, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Suravee, On Wed, Sep 16, 2020 at 01:55:48PM +0000, Suravee Suthikulpanit wrote: > +static void amd_iommu_report_rmp_hw_error(volatile u32 *event) > +{ > + struct pci_dev *pdev; > + struct iommu_dev_data *dev_data = NULL; > + int devid = (event[0] >> EVENT_DEVID_SHIFT) & EVENT_DEVID_MASK; > + int vmg_tag = (event[1]) & 0xFFFF; > + int flags = (event[1] >> EVENT_FLAGS_SHIFT) & EVENT_FLAGS_MASK; > + u64 spa = ((u64)event[3] << 32) | (event[2] & 0xFFFFFFF8); Please write this as: struct iommu_dev_data *dev_data = NULL; int devid, vmg_tag, flags; struct pci_dev *pdev; u64 spa; devid = (event[0] >> EVENT_DEVID_SHIFT) & EVENT_DEVID_MASK; vmg_tag = (event[1]) & 0xFFFF; flags = (event[1] >> EVENT_FLAGS_SHIFT) & EVENT_FLAGS_MASK; spa = ((u64)event[3] << 32) | (event[2] & 0xFFFFFFF8); Same applied the the next function. > + > + pdev = pci_get_domain_bus_and_slot(0, PCI_BUS_NUM(devid), > + devid & 0xff); > + if (pdev) > + dev_data = dev_iommu_priv_get(&pdev->dev); > + > + if (dev_data && __ratelimit(&dev_data->rs)) { > + pci_err(pdev, "Event logged [RMP_HW_ERROR devid=0x%04x, vmg_tag=0x%04x, spa=0x%llx, flags=0x%04x]\n", > + devid, vmg_tag, spa, flags); Printing the devid is not really needed here, no? Same issue in the next function. Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu