From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C2B1C43466 for ; Mon, 21 Sep 2020 16:09:50 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF64520739 for ; Mon, 21 Sep 2020 16:09:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF64520739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 475B020471; Mon, 21 Sep 2020 16:09:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hR+fSRGuYR9E; Mon, 21 Sep 2020 16:09:46 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 1ABA4207A6; Mon, 21 Sep 2020 16:09:46 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CB2DBC0890; Mon, 21 Sep 2020 16:09:45 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id EC0E5C0890 for ; Mon, 21 Sep 2020 16:09:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DA9C6864FB for ; Mon, 21 Sep 2020 16:09:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qJ9aJUy5xtBV for ; Mon, 21 Sep 2020 16:09:42 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by whitealder.osuosl.org (Postfix) with ESMTPS id EFFC1864D2 for ; Mon, 21 Sep 2020 16:09:41 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 52F5168B02; Mon, 21 Sep 2020 18:09:38 +0200 (CEST) Date: Mon, 21 Sep 2020 18:09:38 +0200 From: Christoph Hellwig To: Robin Murphy Subject: Re: [PATCH] iommu/io-pgtable-arm: Clean up faulty sanity check Message-ID: <20200921160938.GB23870@lst.de> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: iommu@lists.linux-foundation.org, james.quinlan@broadcom.com, Naresh Kamboju , will@kernel.org, hch@lst.de, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Sep 21, 2020 at 04:08:01PM +0100, Robin Murphy wrote: > Checking for a nonzero dma_pfn_offset was a quick shortcut to validate > whether the DMA == phys assumption could hold at all. Checking for a > non-NULL dma_range_map is not quite equivalent, since a map may be > present to describe a limited DMA window even without an offset, and > thus this check can now yield false positives. > > However, it only ever served to short-circuit going all the way through > to __arm_lpae_alloc_pages(), failing the canonical test there, and > having a bit more to clean up. As such, we can simply remove it without > loss of correctness. > > Reported-by: Naresh Kamboju > Signed-off-by: Robin Murphy Thanks, applied to the dma-mapping for-next tree. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu