From: Joerg Roedel <joro@8bytes.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
Jacob Pan <jacob.pan.linux@gmail.com>,
Raj Ashok <ashok.raj@intel.com>, Jonathan Corbet <corbet@lwn.net>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
Wu Hao <hao.wu@intel.com>, David Woodhouse <dwmw2@infradead.org>,
Yi Sun <yi.y.sun@intel.com>
Subject: Re: [PATCH v9 3/7] iommu/uapi: Introduce enum type for PASID data format
Date: Thu, 24 Sep 2020 10:40:16 +0200 [thread overview]
Message-ID: <20200924084015.GC27174@8bytes.org> (raw)
In-Reply-To: <20200918101108.672c2f5a@jacob-builder>
Hi Jacob,
On Fri, Sep 18, 2020 at 10:11:08AM -0700, Jacob Pan wrote:
> On Fri, 18 Sep 2020 11:44:50 +0200, Joerg Roedel <joro@8bytes.org> wrote:
>
> > On Fri, Sep 11, 2020 at 02:57:52PM -0700, Jacob Pan wrote:
> > > There can be multiple vendor-specific PASID data formats used in UAPI
> > > structures. This patch adds enum type with a last entry which makes
> > > range checking much easier.
> >
> > But it also makes it much easier to screw up the numbers (which are ABI)
> > by inserting a new value into the middle. I prefer defines here, or
> > alternativly BUILD_BUG_ON() checks for the numbers.
> >
> I am not following, the purpose of IOMMU_PASID_FORMAT_LAST *is* for
> preparing the future insertion of new value into the middle.
> The checking against IOMMU_PASID_FORMAT_LAST is to protect ABI
> compatibility by making sure that out of range format are rejected in all
> versions of the ABI.
But with the enum you could have:
enum {
VTD_FOO,
SMMU_FOO,
LAST,
};
which makes VTD_FOO==0 and SMMU_FOO==1, and when in the next version
someone adds:
enum {
VTD_FOO,
VTD_BAR,
SMMU_FOO,
LAST,
};
then SMMU_FOO will become 2 and break ABI. So I'd like to have this
checked somewhere.
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-09-24 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 21:57 [PATCH v9 0/7] IOMMU user API enhancement Jacob Pan
2020-09-11 21:57 ` [PATCH v9 1/7] docs: IOMMU user API Jacob Pan
2020-09-16 18:26 ` Randy Dunlap
2020-09-18 19:44 ` Jacob Pan
2020-09-11 21:57 ` [PATCH v9 2/7] iommu/uapi: Add argsz for user filled data Jacob Pan
2020-09-11 21:57 ` [PATCH v9 3/7] iommu/uapi: Introduce enum type for PASID data format Jacob Pan
2020-09-18 9:44 ` Joerg Roedel
2020-09-18 17:11 ` Jacob Pan
2020-09-22 20:24 ` Jacob Pan
2020-09-24 8:40 ` Joerg Roedel [this message]
2020-09-24 18:31 ` Jacob Pan
2020-09-11 21:57 ` [PATCH v9 4/7] iommu/uapi: Use named union for user data Jacob Pan
2020-09-11 21:57 ` [PATCH v9 5/7] iommu/uapi: Rename uapi functions Jacob Pan
2020-09-11 21:57 ` [PATCH v9 6/7] iommu/uapi: Handle data and argsz filled by users Jacob Pan
2020-09-11 21:57 ` [PATCH v9 7/7] iommu/vt-d: Check UAPI data processed by IOMMU core Jacob Pan
2020-09-18 10:02 ` [PATCH v9 0/7] IOMMU user API enhancement Joerg Roedel
2020-09-18 17:26 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924084015.GC27174@8bytes.org \
--to=joro@8bytes.org \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=corbet@lwn.net \
--cc=dwmw2@infradead.org \
--cc=hao.wu@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jacob.pan.linux@gmail.com \
--cc=jean-philippe@linaro.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.y.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).