From: Will Deacon <will@kernel.org>
To: Auger Eric <eric.auger@redhat.com>
Cc: tyhicks@linux.microsoft.com, jean-philippe@linaro.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Vennila Megavannan <vemegava@linux.microsoft.com>,
srinath.mannam@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, robin.murphy@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] iommu/arm: Add module parameter to set msi iova address
Date: Mon, 28 Sep 2020 21:56:58 +0100 [thread overview]
Message-ID: <20200928205658.GB12218@willie-the-truck> (raw)
In-Reply-To: <85f7d1ae-71a9-4e95-8a30-03cc699d4794@redhat.com>
On Wed, Sep 23, 2020 at 08:32:43AM +0200, Auger Eric wrote:
> On 9/21/20 10:45 PM, Will Deacon wrote:
> > On Mon, Sep 14, 2020 at 11:13:07AM -0700, Vennila Megavannan wrote:
> >> From: Srinath Mannam <srinath.mannam@broadcom.com>
> >>
> >> Add provision to change default value of MSI IOVA base to platform's
> >> suitable IOVA using module parameter. The present hardcoded MSI IOVA base
> >> may not be the accessible IOVA ranges of platform.
> >>
> >> If any platform has the limitaion to access default MSI IOVA, then it can
> >> be changed using "arm-smmu.msi_iova_base=0xa0000000" command line argument.
> >>
> >> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> >> Co-developed-by: Vennila Megavannan <vemegava@linux.microsoft.com>
> >> Signed-off-by: Vennila Megavannan <vemegava@linux.microsoft.com>
> >> ---
> >> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 5 ++++-
> >> drivers/iommu/arm/arm-smmu/arm-smmu.c | 5 ++++-
> >> 2 files changed, 8 insertions(+), 2 deletions(-)
> >
> > This feels pretty fragile. Wouldn't it be better to realise that there's
> > a region conflict with iommu_dma_get_resv_regions() and move the MSI window
> > accordingly at runtime?
>
> Since cd2c9fcf5c66 ("iommu/dma: Move PCI window region reservation back
> into dma specific path"), the PCI host bridge windows are not exposed by
> iommu_dma_get_resv_regions() anymore. If I understood correctly, what is
> attempted here is to avoid the collision between such PCI host bridge
> window and the MSI IOVA range.
Either way, I think the kernel should figure this out at runtime and not
rely on a cmdline option to tell it where to place the region.
Will
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2020-09-28 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 18:13 [PATCH v2] iommu/arm: Add module parameter to set msi iova address Vennila Megavannan
2020-09-21 20:45 ` Will Deacon
2020-09-22 22:37 ` Vennila Megavannan
2020-09-23 6:32 ` Auger Eric
2020-09-28 20:56 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928205658.GB12218@willie-the-truck \
--to=will@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=srinath.mannam@broadcom.com \
--cc=tyhicks@linux.microsoft.com \
--cc=vemegava@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).