* [PATCH 1/1] iommu/amd: Remove unnecessary assignment
@ 2020-10-12 7:00 Adrian Huang
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Huang @ 2020-10-12 7:00 UTC (permalink / raw)
To: Joerg Roedel; +Cc: iommu, Adrian Huang
From: Adrian Huang <ahuang12@lenovo.com>
The values of local variables are assigned after local variables
are declared, so no need to assign the initial value during the
variable declaration.
And, no need to assign NULL for the local variable 'ivrs_base'
after invoking acpi_put_table().
Signed-off-by: Adrian Huang <ahuang12@lenovo.com>
---
drivers/iommu/amd/init.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index 1ba6b4cc56e8..f171078f7ea0 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -1858,7 +1858,7 @@ static void print_iommu_info(void)
static int __init amd_iommu_init_pci(void)
{
struct amd_iommu *iommu;
- int ret = 0;
+ int ret;
for_each_iommu(iommu) {
ret = iommu_init_pci(iommu);
@@ -2494,8 +2494,8 @@ static void __init free_dma_resources(void)
static int __init early_amd_iommu_init(void)
{
struct acpi_table_header *ivrs_base;
+ int i, remap_cache_sz, ret;
acpi_status status;
- int i, remap_cache_sz, ret = 0;
u32 pci_id;
if (!amd_iommu_detected)
@@ -2637,7 +2637,6 @@ static int __init early_amd_iommu_init(void)
out:
/* Don't leak any ACPI memory */
acpi_put_table(ivrs_base);
- ivrs_base = NULL;
return ret;
}
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH 1/1] iommu/amd: Remove unnecessary assignment
@ 2020-12-09 15:32 Adrian Huang12
2020-12-09 16:56 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Huang12 @ 2020-12-09 15:32 UTC (permalink / raw)
To: Adrian Huang, Joerg Roedel, Will Deacon; +Cc: iommu
Gentle ping.
-- Adrian
> -----Original Message-----
> From: Adrian Huang <adrianhuang0701@gmail.com>
> Sent: Monday, October 12, 2020 3:01 PM
> To: Joerg Roedel <joro@8bytes.org>
> Cc: iommu@lists.linux-foundation.org; Adrian Huang
> <adrianhuang0701@gmail.com>; Adrian Huang12 <ahuang12@lenovo.com>
> Subject: [External] [PATCH 1/1] iommu/amd: Remove unnecessary assignment
>
> From: Adrian Huang <ahuang12@lenovo.com>
>
> The values of local variables are assigned after local variables are declared, so no
> need to assign the initial value during the variable declaration.
>
> And, no need to assign NULL for the local variable 'ivrs_base'
> after invoking acpi_put_table().
>
> Signed-off-by: Adrian Huang <ahuang12@lenovo.com>
> ---
> drivers/iommu/amd/init.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index
> 1ba6b4cc56e8..f171078f7ea0 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -1858,7 +1858,7 @@ static void print_iommu_info(void) static int __init
> amd_iommu_init_pci(void) {
> struct amd_iommu *iommu;
> - int ret = 0;
> + int ret;
>
> for_each_iommu(iommu) {
> ret = iommu_init_pci(iommu);
> @@ -2494,8 +2494,8 @@ static void __init free_dma_resources(void) static int
> __init early_amd_iommu_init(void) {
> struct acpi_table_header *ivrs_base;
> + int i, remap_cache_sz, ret;
> acpi_status status;
> - int i, remap_cache_sz, ret = 0;
> u32 pci_id;
>
> if (!amd_iommu_detected)
> @@ -2637,7 +2637,6 @@ static int __init early_amd_iommu_init(void)
> out:
> /* Don't leak any ACPI memory */
> acpi_put_table(ivrs_base);
> - ivrs_base = NULL;
>
> return ret;
> }
> --
> 2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-09 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 7:00 [PATCH 1/1] iommu/amd: Remove unnecessary assignment Adrian Huang
2020-12-09 15:32 Adrian Huang12
2020-12-09 16:56 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).