From: Alex Williamson <alex.williamson@redhat.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
Kevin Tian <kevin.tian@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
kvm@vger.kernel.org, Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v6 4/5] iommu/vt-d: Add iommu_ops support for subdevice bus
Date: Fri, 30 Oct 2020 14:56:55 -0600 [thread overview]
Message-ID: <20201030145655.07c692d8@w520.home> (raw)
In-Reply-To: <20201030045809.957927-5-baolu.lu@linux.intel.com>
On Fri, 30 Oct 2020 12:58:08 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:
> +static const struct iommu_ops siov_iommu_ops = {
> + .capable = intel_iommu_capable,
> + .domain_alloc = siov_iommu_domain_alloc,
> + .domain_free = intel_iommu_domain_free,
> + .attach_dev = siov_iommu_attach_device,
> + .detach_dev = siov_iommu_detach_device,
> + .map = intel_iommu_map,
> + .unmap = intel_iommu_unmap,
> + .iova_to_phys = intel_iommu_iova_to_phys,
> + .probe_device = siov_iommu_probe_device,
> + .release_device = siov_iommu_release_device,
> + .get_resv_regions = siov_iommu_get_resv_regions,
> + .put_resv_regions = generic_iommu_put_resv_regions,
> + .device_group = generic_device_group,
> + .pgsize_bitmap = (~0xFFFUL),
> +};
> +
> +void intel_siov_init(void)
> +{
> + if (!scalable_mode_support() || !iommu_pasid_support())
> + return;
> +
> + bus_set_iommu(&mdev_bus_type, &siov_iommu_ops);
> + pr_info("Intel(R) Scalable I/O Virtualization supported\n");
> +}
How can you presume to take over iommu_ops for an entire virtual bus?
This also forces mdev and all the dependencies of mdev to be built into
the kernel. I don't find that acceptable. Thanks,
Alex
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-10-30 20:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 4:58 [PATCH v6 0/5] iommu aux-domain APIs extensions Lu Baolu
2020-10-30 4:58 ` [PATCH v6 1/5] vfio/mdev: Register mdev bus earlier during boot Lu Baolu
2020-10-30 17:02 ` Alex Williamson
2020-10-30 4:58 ` [PATCH v6 2/5] iommu: Use bus iommu ops for aux related callback Lu Baolu
2020-10-30 5:55 ` Tian, Kevin
2020-10-30 10:47 ` Jean-Philippe Brucker
2020-10-30 4:58 ` [PATCH v6 3/5] iommu/vt-d: Make some static functions global Lu Baolu
2020-10-30 4:58 ` [PATCH v6 4/5] iommu/vt-d: Add iommu_ops support for subdevice bus Lu Baolu
2020-10-30 6:13 ` Tian, Kevin
2020-10-30 20:56 ` Alex Williamson [this message]
2020-10-30 4:58 ` [PATCH v6 5/5] vfio/type1: Use mdev bus iommu_ops for IOMMU callbacks Lu Baolu
2020-10-30 6:16 ` Tian, Kevin
2020-10-30 21:06 ` Alex Williamson
2020-11-03 5:22 ` Lu Baolu
2020-11-12 2:31 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030145655.07c692d8@w520.home \
--to=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=dave.jiang@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).