iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Jianxiong Gao via iommu <iommu@lists.linux-foundation.org>
To: jxgao@google.com, erdemaktas@google.com, marcorr@google.com,
	hch@lst.de,  m.szyprowski@samsung.com, robin.murphy@arm.com,
	gregkh@linuxfoundation.org, saravanak@google.com,
	heikki.krogerus@linux.intel.com,  rafael.j.wysocki@intel.com,
	andriy.shevchenko@linux.intel.com,  dan.j.williams@intel.com,
	bgolaszewski@baylibre.com, jroedel@suse.de,
	 iommu@lists.linux-foundation.org, konrad.wilk@oracle.com,
	kbusch@kernel.org,  axboe@fb.com, sagi@grimberg.me,
	linux-nvme@lists.infradead.org,  linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] Adding page_offset_mask to device_dma_parameters
Date: Wed, 27 Jan 2021 16:38:27 -0800	[thread overview]
Message-ID: <20210128003829.1892018-2-jxgao@google.com> (raw)
In-Reply-To: <20210128003829.1892018-1-jxgao@google.com>

Some devices rely on the address offset in a page to function
correctly (NVMe driver as an example). These devices may use
a different page size than the Linux kernel. The address offset
has to be preserved upon mapping, and in order to do so, we
need to record the page_offset_mask first.

Signed-off-by: Jianxiong Gao <jxgao@google.com>
---
 include/linux/device.h      |  1 +
 include/linux/dma-mapping.h | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/include/linux/device.h b/include/linux/device.h
index 1779f90eeb4c..f44e0659fc66 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -292,6 +292,7 @@ struct device_dma_parameters {
 	 */
 	unsigned int max_segment_size;
 	unsigned long segment_boundary_mask;
+	unsigned int page_offset_mask;
 };
 
 /**
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 2e49996a8f39..5529a31fefba 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -500,6 +500,23 @@ static inline int dma_set_seg_boundary(struct device *dev, unsigned long mask)
 	return -EIO;
 }
 
+static inline unsigned int dma_get_page_offset_mask(struct device *dev)
+{
+	if (dev->dma_parms)
+		return dev->dma_parms->page_offset_mask;
+	return 0;
+}
+
+static inline int dma_set_page_offset_mask(struct device *dev,
+		unsigned int page_offset_mask)
+{
+	if (dev->dma_parms) {
+		dev->dma_parms->page_offset_mask = page_offset_mask;
+		return 0;
+	}
+	return -EIO;
+}
+
 static inline int dma_get_cache_alignment(void)
 {
 #ifdef ARCH_DMA_MINALIGN
-- 
2.27.0

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-01-28  1:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28  0:38 [PATCH 0/3] Adding offset keeping option when mapping data via SWIOTLB.* Jianxiong Gao via iommu
2021-01-28  0:38 ` Jianxiong Gao via iommu [this message]
2021-01-28 17:27   ` [PATCH 1/3] Adding page_offset_mask to device_dma_parameters Robin Murphy
2021-01-28 18:15     ` Christoph Hellwig
2021-01-28  0:38 ` [PATCH 2/3] Add swiotlb offset preserving mapping when dma_dma_parameters->page_offset_mask is non zero Jianxiong Gao via iommu
2021-01-28 17:15   ` Konrad Rzeszutek Wilk
2021-01-28 17:34     ` Keith Busch
2021-01-28 18:06       ` Jianxiong Gao via iommu
2021-01-28 18:16   ` Christoph Hellwig
2021-01-28  0:38 ` [PATCH 3/3] Adding device_dma_parameters->offset_preserve_mask to NVMe driver Jianxiong Gao via iommu
2021-01-28 18:00   ` Robin Murphy
2021-01-28 18:18     ` Christoph Hellwig
2021-01-28 18:28       ` Jianxiong Gao via iommu
2021-01-28  8:04 ` [PATCH 0/3] Adding offset keeping option when mapping data via SWIOTLB.* Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128003829.1892018-2-jxgao@google.com \
    --to=iommu@lists.linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=axboe@fb.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=dan.j.williams@intel.com \
    --cc=erdemaktas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jroedel@suse.de \
    --cc=jxgao@google.com \
    --cc=kbusch@kernel.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=marcorr@google.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robin.murphy@arm.com \
    --cc=sagi@grimberg.me \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).