From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B0EDC433E0 for ; Thu, 28 Jan 2021 12:17:59 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2A9B64DDC for ; Thu, 28 Jan 2021 12:17:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2A9B64DDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1D89A2E0D8; Thu, 28 Jan 2021 12:17:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z88AXHhhs2wt; Thu, 28 Jan 2021 12:17:55 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 03E012DFF8; Thu, 28 Jan 2021 12:17:55 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id DDD2CC08A1; Thu, 28 Jan 2021 12:17:54 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 054B3C013A for ; Thu, 28 Jan 2021 12:17:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DFD0B86B12 for ; Thu, 28 Jan 2021 12:17:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6uLIS369sVau for ; Thu, 28 Jan 2021 12:17:52 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by whitealder.osuosl.org (Postfix) with ESMTPS id 9D50F86AEB for ; Thu, 28 Jan 2021 12:17:52 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 9A61D51D; Thu, 28 Jan 2021 13:17:49 +0100 (CET) Date: Thu, 28 Jan 2021 13:17:48 +0100 From: Joerg Roedel To: Lu Baolu Subject: Re: [PATCH 1/1] iommu/vt-d: Correctly check addr alignment in qi_flush_dev_iotlb_pasid() Message-ID: <20210128121747.GK32671@8bytes.org> References: <20210119043500.1539596-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210119043500.1539596-1-baolu.lu@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Ashok Raj , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Guo Kaijie , Will Deacon X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Jan 19, 2021 at 12:35:00PM +0800, Lu Baolu wrote: > An incorrect address mask is being used in the qi_flush_dev_iotlb_pasid() > to check the address alignment. This leads to a lot of spurious kernel > warnings: > > [ 485.837093] DMAR: Invalidate non-aligned address 7f76f47f9000, order 0 > [ 485.837098] DMAR: Invalidate non-aligned address 7f76f47f9000, order 0 > [ 492.494145] qi_flush_dev_iotlb_pasid: 5734 callbacks suppressed > [ 492.494147] DMAR: Invalidate non-aligned address 7f7728800000, order 11 > [ 492.508965] DMAR: Invalidate non-aligned address 7f7728800000, order 11 > > Fix it by checking the alignment in right way. > > Fixes: 288d08e780088 ("iommu/vt-d: Handle non-page aligned address") > Reported-and-tested-by: Guo Kaijie > Signed-off-by: Lu Baolu > Cc: Liu Yi L > --- > drivers/iommu/intel/dmar.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied for 5.11, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu