From: David Stevens <stevensd@chromium.org>
To: Maxime Ripard <mripard@kernel.org>
Cc: iommu@lists.linux-foundation.org, linux-sunxi@lists.linux.dev,
David Stevens <stevensd@chromium.org>
Subject: [PATCH] iommu/sun50i: fix protection flag check
Date: Fri, 16 Jul 2021 13:24:31 +0900 [thread overview]
Message-ID: <20210716042431.3195155-1-stevensd@google.com> (raw)
From: David Stevens <stevensd@chromium.org>
Fix RW protection check when making a pte, so that it properly checks
that both R and W flags are set, instead of either R or W.
Signed-off-by: David Stevens <stevensd@chromium.org>
---
drivers/iommu/sun50i-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/sun50i-iommu.c b/drivers/iommu/sun50i-iommu.c
index 181bb1c3437c..11cf5af30956 100644
--- a/drivers/iommu/sun50i-iommu.c
+++ b/drivers/iommu/sun50i-iommu.c
@@ -271,7 +271,7 @@ static u32 sun50i_mk_pte(phys_addr_t page, int prot)
enum sun50i_iommu_aci aci;
u32 flags = 0;
- if (prot & (IOMMU_READ | IOMMU_WRITE))
+ if ((prot & IOMMU_READ) && (prot & IOMMU_WRITE))
aci = SUN50I_IOMMU_ACI_RD_WR;
else if (prot & IOMMU_READ)
aci = SUN50I_IOMMU_ACI_RD;
--
2.32.0.402.g57bb445576-goog
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2021-07-16 4:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 4:24 David Stevens [this message]
2021-07-16 7:31 ` [PATCH] iommu/sun50i: fix protection flag check Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716042431.3195155-1-stevensd@google.com \
--to=stevensd@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).