From: kernel test robot <lkp@intel.com>
To: Sven Peter <sven@svenpeter.dev>, iommu@lists.linux-foundation.org
Cc: Arnd Bergmann <arnd@kernel.org>,
kbuild-all@lists.01.org, Robin Murphy <robin.murphy@arm.com>,
Hector Martin <marcan@marcan.st>,
Alexander Graf <graf@amazon.com>,
Mohamed Mediouni <mohamed.mediouni@caramail.com>,
Will Deacon <will@kernel.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>
Subject: Re: [PATCH v2 4/8] iommu/dma: Support granule > PAGE_SIZE in dma_map_sg
Date: Sun, 29 Aug 2021 06:31:47 +0800 [thread overview]
Message-ID: <202108290648.axRtUqmK-lkp@intel.com> (raw)
In-Reply-To: <20210828153642.19396-5-sven@svenpeter.dev>
[-- Attachment #1: Type: text/plain, Size: 6410 bytes --]
Hi Sven,
I love your patch! Perhaps something to improve:
[auto build test WARNING on iommu/next]
[also build test WARNING on v5.14-rc7 next-20210827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sven-Peter/Support-IOMMU-page-sizes-larger-than-the-CPU-page-size/20210828-233909
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-randconfig-m001-20210827 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/fa978f84667cfd7d8cb467899da60c08321798a5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sven-Peter/Support-IOMMU-page-sizes-larger-than-the-CPU-page-size/20210828-233909
git checkout fa978f84667cfd7d8cb467899da60c08321798a5
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/iommu/dma-iommu.c: In function '__finalise_sg':
drivers/iommu/dma-iommu.c:935:18: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'? [-Werror=implicit-function-declaration]
935 | sg_set_page(s, phys_to_page(sg_phys(s) + s_iova_off), s_length,
| ^~~~~~~~~~~~
| pfn_to_page
>> drivers/iommu/dma-iommu.c:935:18: warning: passing argument 2 of 'sg_set_page' makes pointer from integer without a cast [-Wint-conversion]
935 | sg_set_page(s, phys_to_page(sg_phys(s) + s_iova_off), s_length,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
In file included from include/linux/dma-mapping.h:10,
from include/linux/dma-map-ops.h:9,
from drivers/iommu/dma-iommu.c:13:
include/linux/scatterlist.h:110:69: note: expected 'struct page *' but argument is of type 'int'
110 | static inline void sg_set_page(struct scatterlist *sg, struct page *page,
| ~~~~~~~~~~~~~^~~~
drivers/iommu/dma-iommu.c: In function '__invalidate_sg':
drivers/iommu/dma-iommu.c:982:9: warning: passing argument 2 of 'sg_set_page' makes pointer from integer without a cast [-Wint-conversion]
982 | phys_to_page(sg_phys(s) + sg_dma_address(s)),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
In file included from include/linux/dma-mapping.h:10,
from include/linux/dma-map-ops.h:9,
from drivers/iommu/dma-iommu.c:13:
include/linux/scatterlist.h:110:69: note: expected 'struct page *' but argument is of type 'int'
110 | static inline void sg_set_page(struct scatterlist *sg, struct page *page,
| ~~~~~~~~~~~~~^~~~
drivers/iommu/dma-iommu.c: In function 'iommu_dma_map_sg':
drivers/iommu/dma-iommu.c:1068:18: warning: passing argument 2 of 'sg_set_page' makes pointer from integer without a cast [-Wint-conversion]
1068 | sg_set_page(s, phys_to_page(s_phys - s_iova_off),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
In file included from include/linux/dma-mapping.h:10,
from include/linux/dma-map-ops.h:9,
from drivers/iommu/dma-iommu.c:13:
include/linux/scatterlist.h:110:69: note: expected 'struct page *' but argument is of type 'int'
110 | static inline void sg_set_page(struct scatterlist *sg, struct page *page,
| ~~~~~~~~~~~~~^~~~
cc1: some warnings being treated as errors
vim +/sg_set_page +935 drivers/iommu/dma-iommu.c
913
914 /*
915 * Prepare a successfully-mapped scatterlist to give back to the caller.
916 *
917 * At this point the segments are already laid out by iommu_dma_map_sg() to
918 * avoid individually crossing any boundaries, so we merely need to check a
919 * segment's start address to avoid concatenating across one.
920 */
921 static int __finalise_sg(struct device *dev, struct scatterlist *sg, int nents,
922 dma_addr_t dma_addr)
923 {
924 struct scatterlist *s, *cur = sg;
925 unsigned long seg_mask = dma_get_seg_boundary(dev);
926 unsigned int cur_len = 0, max_len = dma_get_max_seg_size(dev);
927 int i, count = 0;
928
929 for_each_sg(sg, s, nents, i) {
930 /* Restore this segment's original unaligned fields first */
931 unsigned int s_iova_off = sg_dma_address(s);
932 unsigned int s_length = sg_dma_len(s);
933 unsigned int s_iova_len = s->length;
934
> 935 sg_set_page(s, phys_to_page(sg_phys(s) + s_iova_off), s_length,
936 s_iova_off & ~PAGE_MASK);
937 sg_dma_address(s) = DMA_MAPPING_ERROR;
938 sg_dma_len(s) = 0;
939
940 /*
941 * Now fill in the real DMA data. If...
942 * - there is a valid output segment to append to
943 * - and this segment starts on an IOVA page boundary
944 * - but doesn't fall at a segment boundary
945 * - and wouldn't make the resulting output segment too long
946 */
947 if (cur_len && !s_iova_off && (dma_addr & seg_mask) &&
948 (max_len - cur_len >= s_length)) {
949 /* ...then concatenate it with the previous one */
950 cur_len += s_length;
951 } else {
952 /* Otherwise start the next output segment */
953 if (i > 0)
954 cur = sg_next(cur);
955 cur_len = s_length;
956 count++;
957
958 sg_dma_address(cur) = dma_addr + s_iova_off;
959 }
960
961 sg_dma_len(cur) = cur_len;
962 dma_addr += s_iova_len;
963
964 if (s_length + s_iova_off < s_iova_len)
965 cur_len = 0;
966 }
967 return count;
968 }
969
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 43938 bytes --]
[-- Attachment #3: Type: text/plain, Size: 156 bytes --]
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-08-28 22:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 15:36 [PATCH v2 0/8] Support IOMMU page sizes larger than the CPU page size Sven Peter via iommu
2021-08-28 15:36 ` [PATCH v2 1/8] iommu/dma: Align size for untrusted devs to IOVA granule Sven Peter via iommu
2021-08-28 15:36 ` [PATCH v2 2/8] iommu/dma: Fail unaligned map requests for untrusted devs Sven Peter via iommu
2021-08-28 19:00 ` Sven Peter via iommu
2021-08-28 15:36 ` [PATCH v2 3/8] iommu/dma: Disable get_sgtable for granule > PAGE_SIZE Sven Peter via iommu
2021-08-31 21:30 ` Alyssa Rosenzweig
2021-09-01 17:06 ` Sven Peter via iommu
2021-09-01 21:10 ` Alyssa Rosenzweig
2021-09-02 18:19 ` Sven Peter via iommu
2021-09-02 19:42 ` Robin Murphy
2021-09-03 13:11 ` Alyssa Rosenzweig
2021-09-03 15:16 ` Sven Peter via iommu
2021-09-03 15:45 ` Robin Murphy
2021-09-03 16:51 ` Sven Peter via iommu
2021-08-28 15:36 ` [PATCH v2 4/8] iommu/dma: Support granule > PAGE_SIZE in dma_map_sg Sven Peter via iommu
2021-08-28 21:10 ` kernel test robot
2021-08-28 22:31 ` kernel test robot [this message]
2021-08-28 22:33 ` kernel test robot
2021-08-28 15:36 ` [PATCH v2 5/8] iommu/dma: Support PAGE_SIZE < iovad->granule allocations Sven Peter via iommu
2021-08-28 15:36 ` [PATCH v2 6/8] iommu: Move IOMMU pagesize check to attach_device Sven Peter via iommu
2021-08-31 21:39 ` Alyssa Rosenzweig
2021-09-01 17:14 ` Sven Peter via iommu
2021-09-01 18:53 ` Robin Murphy
2021-08-28 15:36 ` [PATCH v2 7/8] iommu: Introduce __IOMMU_DOMAIN_LP Sven Peter via iommu
2021-08-28 15:36 ` [PATCH v2 8/8] iommu/dart: Remove force_bypass logic Sven Peter via iommu
2021-08-31 21:40 ` Alyssa Rosenzweig
2021-08-31 21:32 ` [PATCH v2 0/8] Support IOMMU page sizes larger than the CPU page size Alyssa Rosenzweig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108290648.axRtUqmK-lkp@intel.com \
--to=lkp@intel.com \
--cc=alyssa@rosenzweig.io \
--cc=arnd@kernel.org \
--cc=graf@amazon.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kbuild-all@lists.01.org \
--cc=marcan@marcan.st \
--cc=mohamed.mediouni@caramail.com \
--cc=robin.murphy@arm.com \
--cc=sven@svenpeter.dev \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).