From: Lu Baolu <baolu.lu@linux.intel.com>
To: "Limonciello, Mario" <Mario.Limonciello@dell.com>,
Joerg Roedel <joro@8bytes.org>
Cc: Ashok Raj <ashok.raj@intel.com>,
Christian Kellner <ckellner@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Koba Ko <koba.ko@canonical.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH 1/1] iommu/vt-d: Skip TE disabling on quirky gfx dedicated iommu
Date: Thu, 23 Jul 2020 09:38:29 +0800 [thread overview]
Message-ID: <2695916e-0dfd-6c8a-d4e7-1f4da372e123@linux.intel.com> (raw)
In-Reply-To: <DM6PR19MB263622CA8CAA7CDA3973E0DBFA780@DM6PR19MB2636.namprd19.prod.outlook.com>
On 7/22/20 7:45 AM, Limonciello, Mario wrote:
>
>
>> -----Original Message-----
>> From: Lu Baolu <baolu.lu@linux.intel.com>
>> Sent: Tuesday, July 21, 2020 6:07 PM
>> To: Limonciello, Mario; Joerg Roedel
>> Cc: baolu.lu@linux.intel.com; Ashok Raj; linux-kernel@vger.kernel.org;
>> stable@vger.kernel.org; Koba Ko; iommu@lists.linux-foundation.org
>> Subject: Re: [PATCH 1/1] iommu/vt-d: Skip TE disabling on quirky gfx dedicated
>> iommu
>>
>>
>> [EXTERNAL EMAIL]
>>
>> Hi Limonciello,
>>
>> On 7/21/20 10:44 PM, Limonciello, Mario wrote:
>>>> -----Original Message-----
>>>> From: iommu<iommu-bounces@lists.linux-foundation.org> On Behalf Of Lu
>>>> Baolu
>>>> Sent: Monday, July 20, 2020 7:17 PM
>>>> To: Joerg Roedel
>>>> Cc: Ashok Raj;linux-kernel@vger.kernel.org;stable@vger.kernel.org; Koba
>>>> Ko;iommu@lists.linux-foundation.org
>>>> Subject: [PATCH 1/1] iommu/vt-d: Skip TE disabling on quirky gfx dedicated
>>>> iommu
>>>>
>>>> The VT-d spec requires (10.4.4 Global Command Register, TE field) that:
>>>>
>>>> Hardware implementations supporting DMA draining must drain any in-flight
>>>> DMA read/write requests queued within the Root-Complex before completing
>>>> the translation enable command and reflecting the status of the command
>>>> through the TES field in the Global Status register.
>>>>
>>>> Unfortunately, some integrated graphic devices fail to do so after some
>>>> kind of power state transition. As the result, the system might stuck in
>>>> iommu_disable_translation(), waiting for the completion of TE transition.
>>>>
>>>> This provides a quirk list for those devices and skips TE disabling if
>>>> the qurik hits.
>>>>
>>>> Fixes:https://bugzilla.kernel.org/show_bug.cgi?id=208363
>>> That one is for TGL.
>>>
>>> I think you also want to add this one for ICL:
>>> Fixes:https://bugzilla.kernel.org/show_bug.cgi?id=206571
>>>
>>
>> Do you mean someone have tested that this patch also fixes the problem
>> described in 206571?
>>
>
> Yes, confusingly https://bugzilla.kernel.org/show_bug.cgi?id=208363#c31 actually
> is the XPS 9300 ICL system and issue.
>
> I also have a private confirmation from another person that it resolves it for
> them on another ICL platform.
>
Okay! Thank you very much! I just posted v2 with this tag added.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-07-23 1:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 0:17 [PATCH 1/1] iommu/vt-d: Skip TE disabling on quirky gfx dedicated iommu Lu Baolu
2020-07-21 14:44 ` Limonciello, Mario
2020-07-21 23:06 ` Lu Baolu
2020-07-21 23:45 ` Limonciello, Mario
2020-07-23 1:38 ` Lu Baolu [this message]
2020-07-22 12:15 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2695916e-0dfd-6c8a-d4e7-1f4da372e123@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=ashok.raj@intel.com \
--cc=ckellner@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=koba.ko@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).