From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@infradead.org>,
Krzysztof Wilczynski <kw@linux.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org,
Bjorn Helgaas <helgaas@kernel.org>, Will Deacon <will@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: Move ATS declarations to linux/pci.h
Date: Fri, 30 Aug 2019 17:26:47 +0100 [thread overview]
Message-ID: <26a81b41-515b-2ed8-98db-7ae164ee8dd8@arm.com> (raw)
In-Reply-To: <20190830161840.GA9733@infradead.org>
On 30/08/2019 17:18, Christoph Hellwig wrote:
> On Fri, Aug 30, 2019 at 05:07:56PM +0200, Krzysztof Wilczynski wrote:
>> Move ATS function prototypes from include/linux/pci-ats.h to
>> include/linux/pci.h so users only need to include <linux/pci.h>:
>
> Why is that so important? Very few PCI(e) device drivers use ATS,
> so keeping it out of everyones include hell doesn't seem all bad.
Although to be fair it seems that all the actual ATS stuff already moved
out 4 years ago, so at the very least maybe it would warrant renaming to
pci-pri-pasid.h :)
Robin.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-08-30 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 15:07 [PATCH] PCI: Move ATS declarations to linux/pci.h Krzysztof Wilczynski
2019-08-30 16:18 ` Christoph Hellwig
2019-08-30 16:26 ` Robin Murphy [this message]
2019-09-02 21:11 ` Bjorn Helgaas
2019-09-02 21:38 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26a81b41-515b-2ed8-98db-7ae164ee8dd8@arm.com \
--to=robin.murphy@arm.com \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).