From: Lu Baolu <baolu.lu@linux.intel.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Joerg Roedel <joro@8bytes.org>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org, Will Deacon <will@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/5] iommu: intel: Use generic_iommu_put_resv_regions()
Date: Thu, 19 Dec 2019 09:53:22 +0800 [thread overview]
Message-ID: <2b3020a1-221c-f86b-6440-e9ef65f0c12e@linux.intel.com> (raw)
In-Reply-To: <20191218134205.1271740-5-thierry.reding@gmail.com>
Please tweak the title to
"iommu/vt-d: Use generic_iommu_put_resv_regions()"
then,
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
On 12/18/19 9:42 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Use the new standard function instead of open-coding it.
>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/iommu/intel-iommu.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 42966611a192..a6d5b7cf9183 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -5744,15 +5744,6 @@ static void intel_iommu_get_resv_regions(struct device *device,
> list_add_tail(®->list, head);
> }
>
> -static void intel_iommu_put_resv_regions(struct device *dev,
> - struct list_head *head)
> -{
> - struct iommu_resv_region *entry, *next;
> -
> - list_for_each_entry_safe(entry, next, head, list)
> - kfree(entry);
> -}
> -
> int intel_iommu_enable_pasid(struct intel_iommu *iommu, struct device *dev)
> {
> struct device_domain_info *info;
> @@ -5987,7 +5978,7 @@ const struct iommu_ops intel_iommu_ops = {
> .add_device = intel_iommu_add_device,
> .remove_device = intel_iommu_remove_device,
> .get_resv_regions = intel_iommu_get_resv_regions,
> - .put_resv_regions = intel_iommu_put_resv_regions,
> + .put_resv_regions = generic_iommu_put_resv_regions,
> .apply_resv_region = intel_iommu_apply_resv_region,
> .device_group = pci_device_group,
> .dev_has_feat = intel_iommu_dev_has_feat,
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-12-19 1:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 13:42 [PATCH v3 0/5] iommu: Implement generic_iommu_put_resv_regions() Thierry Reding
2019-12-18 13:42 ` [PATCH v3 1/5] " Thierry Reding
2019-12-18 13:42 ` [PATCH v3 2/5] iommu: arm: Use generic_iommu_put_resv_regions() Thierry Reding
2019-12-18 13:42 ` [PATCH v3 3/5] iommu: amd: " Thierry Reding
2019-12-18 13:42 ` [PATCH v3 4/5] iommu: intel: " Thierry Reding
2019-12-19 1:53 ` Lu Baolu [this message]
2019-12-19 12:47 ` Thierry Reding
2019-12-19 15:35 ` Joerg Roedel
2019-12-18 13:42 ` [PATCH v3 5/5] iommu: virtio: " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b3020a1-221c-f86b-6440-e9ef65f0c12e@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).