From: Lu Baolu <baolu.lu@linux.intel.com>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] intel-iommu: Turn off translations at shutdown
Date: Sat, 9 Nov 2019 08:35:33 +0800 [thread overview]
Message-ID: <2f09d7f4-6c9a-91f1-4618-c196f46870b9@linux.intel.com> (raw)
In-Reply-To: <CABeXuvpHYTU8qT5_+vxGUfLN34b6n-dF_5=KfRYp4eY22D8CKA@mail.gmail.com>
Hi,
On 11/9/19 6:28 AM, Deepa Dinamani wrote:
>>> + x86_platform.iommu_shutdown = intel_iommu_shutdown;
>>
>> How about moving it to detect_intel_iommu() in drivers/iommu/dmar.c? And
>
> Ok, makes sense to move it along with the init handler.
>
>> make sure that it's included with CONFIG_X86_64.
>
> You mean CONFIG_X86 like the init that is already there?
>
> #ifdef CONFIG_X86
> if (!ret)
> x86_init.iommu.iommu_init = intel_iommu_init;
> #endif
>
Yes.
Also, change the title to "iommu/vt-d: Turn off ..."
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-11-09 0:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 20:59 [PATCH] intel-iommu: Turn off translations at shutdown Deepa Dinamani
2019-11-07 21:27 ` Deepa Dinamani
2019-11-08 3:07 ` Lu Baolu
2019-11-08 3:06 ` Lu Baolu
2019-11-08 22:28 ` Deepa Dinamani
2019-11-09 0:35 ` Lu Baolu [this message]
2019-11-08 7:54 ` David Woodhouse
2019-11-08 8:47 ` Zeng, Jason
2019-11-08 8:57 ` David Woodhouse
2019-11-08 9:11 ` Zeng, Jason
2019-11-08 22:48 ` Deepa Dinamani
2019-11-10 18:24 ` Deepa Dinamani
2019-11-10 20:36 ` Deepa Dinamani
2019-11-11 2:35 ` Zeng, Jason
2019-11-11 0:39 ` Zeng, Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f09d7f4-6c9a-91f1-4618-c196f46870b9@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=deepa.kernel@gmail.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).