From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
iommu@lists.linux-foundation.org
Cc: jon@solid-run.com, linuxarm@huawei.com, steven.price@arm.com,
guohanjun@huawei.com, yangyicong@huawei.com,
Sami.Mujawar@arm.com, robin.murphy@arm.com,
wanghuiqiang@huawei.com
Subject: Re: [PATCH v6 0/9] ACPI/IORT: Support for IORT RMR node
Date: Mon, 19 Jul 2021 16:45:33 +0300 [thread overview]
Message-ID: <35db3320-d6e2-721e-8d49-e5e2e80e2359@nxp.com> (raw)
In-Reply-To: <20210716083442.1708-1-shameerali.kolothum.thodi@huawei.com>
On 7/16/2021 11:34 AM, Shameer Kolothum wrote:
> Hi,
>
> Major Changes from v5:
> - Addressed comments from Robin & Lorenzo.
> : Moved iort_parse_rmr() to acpi_iort_init() from
> iort_init_platform_devices().
> : Removed use of struct iort_rmr_entry during the initial
> parse. Using struct iommu_resv_region instead.
> : Report RMR address alignment and overlap errors, but continue.
> : Reworked arm_smmu_init_bypass_stes() (patch # 6).
> - Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8).
> - Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based
> on Type of RMR region. Suggested by Jon N.
>
> Sanity tested on a HiSilicon D06(SMMUv3). Further testing and
> feedback is greatly appreciated.
>
> Thanks,
> Shameer
>
> ------
> v4 --> v5
> -Added a fw_data union to struct iommu_resv_region and removed
> struct iommu_rmr (Based on comments from Joerg/Robin).
> -Added iommu_put_rmrs() to release mem.
> -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by
> yet because of the above changes.
>
> v3 -->v4
> -Included the SMMUv2 SMR bypass install changes suggested by
> Steve(patch #7)
> -As per Robin's comments, RMR reserve implementation is now
> more generic (patch #8) and dropped v3 patches 8 and 10.
> -Rebase to 5.13-rc1
>
> RFC v2 --> v3
> -Dropped RFC tag as the ACPICA header changes are now ready to be
> part of 5.13[0]. But this series still has a dependency on that patch.
> -Added IORT E.b related changes(node flags, _DSM function 5 checks for
> PCIe).
> -Changed RMR to stream id mapping from M:N to M:1 as per the spec and
> discussion here[1].
> -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!)
> ------
>
> Jon Nettleton (1):
> iommu/arm-smmu: Get associated RMR info and install bypass SMR
>
> Shameer Kolothum (8):
> iommu: Introduce a union to struct iommu_resv_region
> ACPI/IORT: Add support for RMR node parsing
> iommu/dma: Introduce generic helper to retrieve RMR info
> ACPI/IORT: Add a helper to retrieve RMR memory regions
> iommu/arm-smmu-v3: Introduce strtab init helper
> iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force
> bypass
> iommu/arm-smmu-v3: Get associated RMR info and install bypass STE
> iommu/dma: Reserve any RMR regions associated with a dev
>
> drivers/acpi/arm64/iort.c | 172 +++++++++++++++++++-
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 76 +++++++--
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 48 ++++++
> drivers/iommu/dma-iommu.c | 89 +++++++++-
> include/linux/acpi_iort.h | 7 +
> include/linux/dma-iommu.h | 13 ++
> include/linux/iommu.h | 11 ++
> 7 files changed, 393 insertions(+), 23 deletions(-)
>
Validated on a NXP LX2160A with SMMUv2, so:
Tested-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
Thanks & Best Regards, Laurentiu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-07-19 13:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 8:34 [PATCH v6 0/9] ACPI/IORT: Support for IORT RMR node Shameer Kolothum
2021-07-16 8:34 ` [PATCH v6 1/9] iommu: Introduce a union to struct iommu_resv_region Shameer Kolothum
2021-07-16 8:34 ` [PATCH v6 2/9] ACPI/IORT: Add support for RMR node parsing Shameer Kolothum
2021-07-16 8:34 ` [PATCH v6 3/9] iommu/dma: Introduce generic helper to retrieve RMR info Shameer Kolothum
2021-07-16 8:34 ` [PATCH v6 4/9] ACPI/IORT: Add a helper to retrieve RMR memory regions Shameer Kolothum
2021-07-16 8:34 ` [PATCH v6 5/9] iommu/arm-smmu-v3: Introduce strtab init helper Shameer Kolothum
2021-07-16 8:34 ` [PATCH v6 6/9] iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force bypass Shameer Kolothum
2021-07-16 8:34 ` [PATCH v6 7/9] iommu/arm-smmu-v3: Get associated RMR info and install bypass STE Shameer Kolothum
2021-07-16 8:34 ` [PATCH v6 8/9] iommu/arm-smmu: Get associated RMR info and install bypass SMR Shameer Kolothum
2021-07-16 13:52 ` Steven Price
2021-07-16 20:40 ` Jon Nettleton
2021-07-16 8:34 ` [PATCH v6 9/9] iommu/dma: Reserve any RMR regions associated with a dev Shameer Kolothum
2021-07-19 13:45 ` Laurentiu Tudor [this message]
2021-07-27 6:51 ` [PATCH v6 0/9] ACPI/IORT: Support for IORT RMR node Shameerali Kolothum Thodi
2021-08-02 9:22 ` joro
2021-07-27 8:32 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35db3320-d6e2-721e-8d49-e5e2e80e2359@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=Sami.Mujawar@arm.com \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jon@solid-run.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=steven.price@arm.com \
--cc=wanghuiqiang@huawei.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).