From: Qian Cai <cai@lca.pw>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] iommu/amd: fix a race in fetch_pte()
Date: Sun, 19 Apr 2020 22:07:19 -0400 [thread overview]
Message-ID: <3733C20F-46C0-4C4F-9E37-94D361377D51@lca.pw> (raw)
In-Reply-To: <20200418183429.GH21900@8bytes.org>
> On Apr 18, 2020, at 2:34 PM, Joerg Roedel <joro@8bytes.org> wrote:
>
> On Sat, Apr 18, 2020 at 09:01:35AM -0400, Qian Cai wrote:
>> Hard to tell without testing further. I’ll leave that optimization in
>> the future, and focus on fixing those races first.
>
> Yeah right, we should fix the existing races first before introducing
> new ones ;)
>
> Btw, THANKS A LOT for tracking down all these race condition bugs, I am
> not even remotely able to trigger them with the hardware I have around.
>
> I did some hacking and the attached diff shows how I think this race
> condition needs to be fixed. I boot-tested this fix on-top of v5.7-rc1,
> but did no further testing. Can you test it please?
Sure, give it a few days to see if it could survive.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-04-20 2:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 2:12 [RFC PATCH] iommu/amd: fix a race in fetch_pte() Qian Cai
2020-04-07 15:36 ` Qian Cai
2020-04-08 14:19 ` Joerg Roedel
2020-04-14 1:36 ` Qian Cai
2020-04-17 1:42 ` Qian Cai
2020-04-18 12:10 ` Joerg Roedel
2020-04-18 13:01 ` Qian Cai
2020-04-18 18:34 ` Joerg Roedel
2020-04-20 2:07 ` Qian Cai [this message]
2020-04-20 13:26 ` Qian Cai
2020-04-29 8:47 ` Joerg Roedel
2020-04-29 11:20 ` Joerg Roedel
2020-04-30 1:04 ` Qian Cai
2020-05-03 13:04 ` Qian Cai
2020-05-03 18:39 ` Joerg Roedel
2020-05-03 19:12 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3733C20F-46C0-4C4F-9E37-94D361377D51@lca.pw \
--to=cai@lca.pw \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).