iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Christoph Hellwig <hch@lst.de>, Florian Fainelli <f.fainelli@gmail.com>
Cc: alexey.skidanov@intel.com, linux-kernel@vger.kernel.org,
	"open list:DMA MAPPING HELPERS"
	<iommu@lists.linux-foundation.org>,
	bcm-kernel-feedback-list@broadcom.com, akpm@linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>,
	sjhuang@iluvatar.ai
Subject: Re: [PATCH] dma-remap: Avoid de-referencing NULL atomic_pool
Date: Tue, 11 Jun 2019 09:44:47 -0700	[thread overview]
Message-ID: <3d19909d-0b1b-5641-6698-6bd38c924f81@gmail.com> (raw)
In-Reply-To: <20190611052630.GA19263@lst.de>

On 6/10/19 10:26 PM, Christoph Hellwig wrote:
> Looks good to me.  When did this start to show up?  Do we need
> to push it to Linus this cycle and cc stable?

You need a really contrived memory map layout to reach that situation,
so I don't think it warrants a stable backport.

For ARM64, this seems to date back to 3.18 with
d4932f9e81ae7a7bf3c3967e48373909b9c98ee5 ("arm64: add atomic pool for
non-coherent and CMA allocations") and for ARM 32-bit, I don't think you
could hit that condition since it would mean no lowmem, which would not
lead to a working kernel.
-- 
Florian
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2019-06-11 16:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190607234333.9776-1-f.fainelli@gmail.com>
2019-06-10 22:54 ` [PATCH] dma-remap: Avoid de-referencing NULL atomic_pool Florian Fainelli
2019-06-11  5:26   ` Christoph Hellwig
2019-06-11 16:44     ` Florian Fainelli [this message]
2019-06-14 12:30   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d19909d-0b1b-5641-6698-6bd38c924f81@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexey.skidanov@intel.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sjhuang@iluvatar.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).