From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
Joerg Roedel <joro@8bytes.org>,
"Raj, Ashok" <ashok.raj@intel.com>,
Jason Gunthorpe <jgg@nvidia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>
Subject: Re: [PATCH 1/1] iommu/vt-d: Add set_dev_pasid callbacks for default domain
Date: Tue, 14 Jun 2022 14:13:07 +0800 [thread overview]
Message-ID: <3e2e6ee7-984f-254e-7a3e-e32d6256c8f2@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB5276DF2C87451A1164A995FB8CAA9@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2022/6/14 13:36, Tian, Kevin wrote:
>> From: Baolu Lu<baolu.lu@linux.intel.com>
>> Sent: Tuesday, June 14, 2022 12:48 PM
>>
>> On 2022/6/14 12:02, Tian, Kevin wrote:
>>>> From: Lu Baolu<baolu.lu@linux.intel.com>
>>>> Sent: Tuesday, June 14, 2022 11:44 AM
>>>>
>>>> This allows the upper layers to set a domain to a PASID of a device
>>>> if the PASID feature is supported by the IOMMU hardware. The typical
>>>> use cases are, for example, kernel DMA with PASID and hardware
>>>> assisted mediated device drivers.
>>>>
>>> why is it not part of the series for those use cases? There is no consumer
>>> of added callbacks in this patch...
>> It could be. I just wanted to maintain the integrity of Intel IOMMU
>> driver implementation.
> but let's not add dead code. and this patch is actually a right step
> simply from set_dev_pasid() p.o.v hence you should include in any
> series which first tries to use that interface.
>
Yes, that's my intention. If it reviews well, we can include it in the
driver's implementation.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-06-14 6:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 3:44 [PATCH 1/1] iommu/vt-d: Add set_dev_pasid callbacks for default domain Lu Baolu
2022-06-14 4:02 ` Tian, Kevin
2022-06-14 4:48 ` Baolu Lu
2022-06-14 5:36 ` Tian, Kevin
2022-06-14 6:13 ` Baolu Lu [this message]
2022-06-14 7:19 ` Tian, Kevin
2022-06-14 7:48 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e2e6ee7-984f-254e-7a3e-e32d6256c8f2@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).