Re: [PATCH 2/2] dma-debug: remove all exports

[Robin Murphy <robin.murphy@arm.com>]

On 2020-09-08 17:39, Christoph Hellwig wrote:
> Now that the main dma mapping entry points are out of line none
> of these functions can be called from modular code.

FWIW I did briefly look at how much of dma-debug we could drop from 
dma-mapping.h and make entirely private to kernel/dma/, but couldn't 
convince myself that an awkward split with a few calls still needing to 
be public would be worthwhile.

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   kernel/dma/debug.c | 12 ------------
>   1 file changed, 12 deletions(-)
> 
> diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
> index 8e9f7b301c6d39..9e5370e3700c08 100644
> --- a/kernel/dma/debug.c
> +++ b/kernel/dma/debug.c
> @@ -1199,7 +1199,6 @@ void debug_dma_map_single(struct device *dev, const void *addr,
>   		err_printk(dev, NULL, "device driver maps memory from vmalloc area [addr=%p] [len=%lu]\n",
>   			   addr, len);
>   }
> -EXPORT_SYMBOL(debug_dma_map_single);

This is still called inline via dma_map_single_attrs(), no?

>   void debug_dma_map_page(struct device *dev, struct page *page, size_t offset,
>   			size_t size, int direction, dma_addr_t dma_addr)
> @@ -1235,7 +1234,6 @@ void debug_dma_map_page(struct device *dev, struct page *page, size_t offset,
>   
>   	add_dma_entry(entry);
>   }
> -EXPORT_SYMBOL(debug_dma_map_page);
>   
>   void debug_dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
>   {
> @@ -1273,7 +1271,6 @@ void debug_dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
>   
>   	put_hash_bucket(bucket, flags);
>   }
> -EXPORT_SYMBOL(debug_dma_mapping_error);

Ditto this for dma_mapping_error(). We hardly want to discourage modules 
from calling that ;)

With those fixed (unless I've missed some other preceding change),

Reviewed-by: Robin Murphy <robin.murphy@arm.com>

Cheers,
Robin.

>   void debug_dma_unmap_page(struct device *dev, dma_addr_t addr,
>   			  size_t size, int direction)
> @@ -1290,7 +1287,6 @@ void debug_dma_unmap_page(struct device *dev, dma_addr_t addr,
>   		return;
>   	check_unmap(&ref);
>   }
> -EXPORT_SYMBOL(debug_dma_unmap_page);
>   
>   void debug_dma_map_sg(struct device *dev, struct scatterlist *sg,
>   		      int nents, int mapped_ents, int direction)
> @@ -1328,7 +1324,6 @@ void debug_dma_map_sg(struct device *dev, struct scatterlist *sg,
>   		add_dma_entry(entry);
>   	}
>   }
> -EXPORT_SYMBOL(debug_dma_map_sg);
>   
>   static int get_nr_mapped_entries(struct device *dev,
>   				 struct dma_debug_entry *ref)
> @@ -1380,7 +1375,6 @@ void debug_dma_unmap_sg(struct device *dev, struct scatterlist *sglist,
>   		check_unmap(&ref);
>   	}
>   }
> -EXPORT_SYMBOL(debug_dma_unmap_sg);
>   
>   void debug_dma_alloc_coherent(struct device *dev, size_t size,
>   			      dma_addr_t dma_addr, void *virt)
> @@ -1466,7 +1460,6 @@ void debug_dma_map_resource(struct device *dev, phys_addr_t addr, size_t size,
>   
>   	add_dma_entry(entry);
>   }
> -EXPORT_SYMBOL(debug_dma_map_resource);
>   
>   void debug_dma_unmap_resource(struct device *dev, dma_addr_t dma_addr,
>   			      size_t size, int direction)
> @@ -1484,7 +1477,6 @@ void debug_dma_unmap_resource(struct device *dev, dma_addr_t dma_addr,
>   
>   	check_unmap(&ref);
>   }
> -EXPORT_SYMBOL(debug_dma_unmap_resource);
>   
>   void debug_dma_sync_single_for_cpu(struct device *dev, dma_addr_t dma_handle,
>   				   size_t size, int direction)
> @@ -1503,7 +1495,6 @@ void debug_dma_sync_single_for_cpu(struct device *dev, dma_addr_t dma_handle,
>   
>   	check_sync(dev, &ref, true);
>   }
> -EXPORT_SYMBOL(debug_dma_sync_single_for_cpu);
>   
>   void debug_dma_sync_single_for_device(struct device *dev,
>   				      dma_addr_t dma_handle, size_t size,
> @@ -1523,7 +1514,6 @@ void debug_dma_sync_single_for_device(struct device *dev,
>   
>   	check_sync(dev, &ref, false);
>   }
> -EXPORT_SYMBOL(debug_dma_sync_single_for_device);
>   
>   void debug_dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg,
>   			       int nelems, int direction)
> @@ -1556,7 +1546,6 @@ void debug_dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg,
>   		check_sync(dev, &ref, true);
>   	}
>   }
> -EXPORT_SYMBOL(debug_dma_sync_sg_for_cpu);
>   
>   void debug_dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
>   				  int nelems, int direction)
> @@ -1588,7 +1577,6 @@ void debug_dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
>   		check_sync(dev, &ref, false);
>   	}
>   }
> -EXPORT_SYMBOL(debug_dma_sync_sg_for_device);
>   
>   static int __init dma_debug_driver_setup(char *str)
>   {
> 
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu