From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Christoph Hellwig <hch@lst.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org,
Michael Ellerman <mpe@ellerman.id.au>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line
Date: Wed, 15 Apr 2020 21:21:37 +1000 [thread overview]
Message-ID: <5139e8e1-6389-3387-dc39-6983b08ff28d@ozlabs.ru> (raw)
In-Reply-To: <20200415061859.GA32392@lst.de>
On 15/04/2020 16:18, Christoph Hellwig wrote:
> On Wed, Apr 15, 2020 at 12:26:04PM +1000, Alexey Kardashevskiy wrote:
>> May be this is correct and allowed (no idea) but removing exported
>> symbols at least deserves a mention in the commit log, does not it?
>>
>> The rest of the series is fine and works. Thanks,
>
> Maybe I can throw in a line, but the point is that dma_direct_*
> was exported as dma_* called them inline. Now dma_* is out of line
> and exported instead, which always was the actual API.
They become inline in 2/4.
And the fact they were exported leaves possibility that there is a
driver somewhere relying on these symbols or distro kernel won't build
because the symbol disappeared from exports (I do not know what KABI
guarantees or if mainline kernel cares). I do not care in particular but
some might, a line separated with empty lines in the commit log would do.
--
Alexey
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-04-15 11:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 12:25 generic DMA bypass flag v3 Christoph Hellwig
2020-04-14 12:25 ` [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line Christoph Hellwig
2020-04-15 2:26 ` Alexey Kardashevskiy
2020-04-15 6:18 ` Christoph Hellwig
2020-04-15 11:21 ` Alexey Kardashevskiy [this message]
2020-04-17 7:58 ` Christoph Hellwig
2020-05-05 4:18 ` Alexey Kardashevskiy
2020-05-09 8:19 ` Christoph Hellwig
2020-05-09 14:07 ` Alexey Kardashevskiy
2020-06-03 4:13 ` Alexey Kardashevskiy
2020-07-07 0:43 ` Alexey Kardashevskiy
2020-07-07 14:51 ` Christoph Hellwig
2020-04-14 12:25 ` [PATCH 2/4] dma-mapping: inline the fast path dma-direct calls Christoph Hellwig
2020-04-14 12:25 ` [PATCH 3/4] dma-mapping: add a dma_ops_bypass flag to struct device Christoph Hellwig
2020-04-14 12:47 ` Greg Kroah-Hartman
2020-04-18 12:42 ` Joerg Roedel
2020-04-19 8:00 ` Christoph Hellwig
2020-04-19 12:25 ` Joerg Roedel
2020-04-19 14:46 ` Alexey Kardashevskiy
2020-04-14 12:25 ` [PATCH 4/4] powerpc: use the generic dma_ops_bypass mode Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5139e8e1-6389-3387-dc39-6983b08ff28d@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).