From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E230C2D0F0 for ; Mon, 30 Mar 2020 20:42:24 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D328B20786 for ; Mon, 30 Mar 2020 20:42:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="SoqkNnxD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D328B20786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lists.linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id AB7A387D75; Mon, 30 Mar 2020 20:42:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hRdyi6v2WZSU; Mon, 30 Mar 2020 20:42:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 73DFC855F7; Mon, 30 Mar 2020 20:42:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 59D67C1D7E; Mon, 30 Mar 2020 20:42:22 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8A4DBC07FF for ; Mon, 30 Mar 2020 20:42:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 78CE820416 for ; Mon, 30 Mar 2020 20:42:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZwKInkD2G8rc for ; Mon, 30 Mar 2020 20:42:19 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from smtp-fw-9101.amazon.com (smtp-fw-9101.amazon.com [207.171.184.25]) by silver.osuosl.org (Postfix) with ESMTPS id 923F82034D for ; Mon, 30 Mar 2020 20:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1585600940; x=1617136940; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=pzei7EPNdSl0vQstWZdYvFBARJOekVDWFMh3y2n4Zzg=; b=SoqkNnxDDNpLJEjSehgHaebK+wGoVdRSn1EUjoFNeiLFwvu+XsbQ52Wb WFIYkGy9huKpC9aYl7CpIqR0zH/6qnFmDeLNj2BoAJ1/HSoJbiPbbCK7b 6FktbahnxEU1cznScP+FEEL1r5VaNTna9q+cTStoIFd+OZJ76CGnHqytR g=; IronPort-SDR: ZQ+rhy1V3tG9tO8gx4zMdwYV99PRd2MSqkQa6tUb6O30D5v+rRPtyfdHoJg1n+6rvekwp2wRW2 RRTQjGuwOMAQ== X-IronPort-AV: E=Sophos;i="5.72,325,1580774400"; d="scan'208";a="25953907" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1a-16acd5e0.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9101.sea19.amazon.com with ESMTP; 30 Mar 2020 20:42:17 +0000 Received: from EX13MTAUWC001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1a-16acd5e0.us-east-1.amazon.com (Postfix) with ESMTPS id C9F3AA2992; Mon, 30 Mar 2020 20:42:09 +0000 (UTC) Received: from EX13D20UWC001.ant.amazon.com (10.43.162.244) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 30 Mar 2020 20:42:09 +0000 Received: from 38f9d3867b82.ant.amazon.com (10.43.162.134) by EX13D20UWC001.ant.amazon.com (10.43.162.244) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 30 Mar 2020 20:42:02 +0000 Subject: Re: [PATCH] swiotlb: Allow swiotlb to live at pre-defined address To: Konrad Rzeszutek Wilk , Kairui Song , , Jan Setje-Eilers References: <20200326162922.27085-1-graf@amazon.com> <20200328115733.GA67084@dhcp-128-65.nay.redhat.com> <20200330134004.GA31026@char.us.oracle.com> Message-ID: <51432837-8804-0600-c7a3-8849506f999e@amazon.com> Date: Mon, 30 Mar 2020 22:42:00 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200330134004.GA31026@char.us.oracle.com> Content-Language: en-US X-Originating-IP: [10.43.162.134] X-ClientProxiedBy: EX13D10UWB002.ant.amazon.com (10.43.161.130) To EX13D20UWC001.ant.amazon.com (10.43.162.244) Cc: Mark Rutland , brijesh.singh@amd.com, Lianbo Jiang , linux-doc@vger.kernel.org, Jan Kiszka , "Schoenherr, Jan H." , Christoph Hellwig , the arch/x86 maintainers , Laszlo Ersek , aggh@amazon.com, "Lendacky, Thomas" , alcioa@amazon.com, dhr@amazon.com, benh@amazon.com, Dave Young , kexec@lists.infradead.org, Linux Kernel Mailing List , iommu@lists.linux-foundation.org, aagch@amazon.com, Robin Murphy , dwmw@amazon.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Graf via iommu Reply-To: Alexander Graf Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 30.03.20 15:40, Konrad Rzeszutek Wilk wrote: > > > > On Mon, Mar 30, 2020 at 02:06:01PM +0800, Kairui Song wrote: >> On Sat, Mar 28, 2020 at 7:57 PM Dave Young wrote: >>> >>> On 03/26/20 at 05:29pm, Alexander Graf wrote: >>>> The swiotlb is a very convenient fallback mechanism for bounce buffering of >>>> DMAable data. It is usually used for the compatibility case where devices >>>> can only DMA to a "low region". >>>> >>>> However, in some scenarios this "low region" may be bound even more >>>> heavily. For example, there are embedded system where only an SRAM region >>>> is shared between device and CPU. There are also heterogeneous computing >>>> scenarios where only a subset of RAM is cache coherent between the >>>> components of the system. There are partitioning hypervisors, where >>>> a "control VM" that implements device emulation has limited view into a >>>> partition's memory for DMA capabilities due to safety concerns. >>>> >>>> This patch adds a command line driven mechanism to move all DMA memory into >>>> a predefined shared memory region which may or may not be part of the >>>> physical address layout of the Operating System. >>>> >>>> Ideally, the typical path to set this configuration would be through Device >>>> Tree or ACPI, but neither of the two mechanisms is standardized yet. Also, >>>> in the x86 MicroVM use case, we have neither ACPI nor Device Tree, but >>>> instead configure the system purely through kernel command line options. >>>> >>>> I'm sure other people will find the functionality useful going forward >>>> though and extend it to be triggered by DT/ACPI in the future. >>> >>> Hmm, we have a use case for kdump, this maybe useful. For example >>> swiotlb is enabled by default if AMD SME/SEV is active, and in kdump >>> kernel we have to increase the crashkernel reserved size for the extra >>> swiotlb requirement. I wonder if we can just reuse the old kernel's >>> swiotlb region and pass the addr to kdump kernel. >>> >> >> Yes, definitely helpful for kdump kernel. This can help reduce the >> crashkernel value. >> >> Previously I was thinking about something similar, play around the >> e820 entry passed to kdump and let it place swiotlb in wanted region. >> Simply remap it like in this patch looks much cleaner. >> >> If this patch is acceptable, one more patch is needed to expose the >> swiotlb in iomem, so kexec-tools can pass the right kernel cmdline to >> second kernel. > > We seem to be passsing a lot of data to kexec.. Perhaps something > of a unified way since we seem to have a lot of things to pass - disabling > IOMMU, ACPI RSDT address, and then this. > > CC-ing Anthony who is working on something - would you by any chance > have a doc on this? I see in general 2 use cases here: 1) Allow for a generic mechanism to have the fully system, individual buses, devices or functions of a device go through a particular, self-contained bounce buffer. This sounds like the holy grail to a lot of problems. It would solve typical embedded scenarios where you only have a shared SRAM. It solves the safety case (to some extent) where you need to ensure that one device interaction doesn't conflict with another device interaction. It also solves the problem I've tried to solve with the patch here. It's unfortunately a lot harder than the patch I sent, so it will take me some time to come up with a working patch set.. I suppose starting with a DT binding only is sensible. Worst case, x86 does also support DT ... (And yes, I'm always happy to review patches if someone else beats me to it) 2) Reuse the SWIOTLB from the previous boot on kexec/kdump I see little direct relation to SEV here. The only reason SEV makes it more relevant, is that you need to have an SWIOTLB region available with SEV while without you could live with a disabled IOMMU. However, I can definitely understand how you would want to have a way to tell the new kexec'ed kernel where the old SWIOTLB was, so it can reuse its memory for its own SWIOTLB. That way, you don't have to reserve another 64MB of RAM for kdump. What I'm curious on is whether we need to be as elaborate. Can't we just pass the old SWIOTLB as free memory to the new kexec'ed kernel and everything else will fall into place? All that would take is a bit of shuffling on the e820 table pass-through to the kexec'ed kernel, no? Thanks, Alex Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu