From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iommu/vt-d: Remove commented-out code
Date: Mon, 12 Jun 2023 11:15:09 -0700 [thread overview]
Message-ID: <54wdooghiofgutm73l6klmr6kkalwxuw46l3kxqgccwkta3brz@dezrf7rslvl7> (raw)
In-Reply-To: <20230609060514.15154-1-baolu.lu@linux.intel.com>
On Fri, Jun 09, 2023 at 02:05:14PM +0800, Lu Baolu wrote:
> These lines of code were commented out when they were first added in commit
> ba39592764ed ("Intel IOMMU: Intel IOMMU driver"). We do not want to restore
> them because the VT-d spec has deprecated the read/write draining hit.
>
> VT-d spec (section 11.4.2):
> "
> Hardware implementation with Major Version 2 or higher (VER_REG), always
> performs required drain without software explicitly requesting a drain in
> IOTLB invalidation. This field is deprecated and hardware will always
> report it as 1 to maintain backward compatibility with software.
> "
>
> Remove the code to make the code cleaner.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
> ---
> drivers/iommu/intel/iommu.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 4c0b7424c45e..e5c111ff4dd9 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -1312,15 +1312,7 @@ static void __iommu_flush_iotlb(struct intel_iommu *iommu, u16 did,
> iommu->name, type);
> return;
> }
> - /* Note: set drain read/write */
> -#if 0
> - /*
> - * This is probably to be super secure.. Looks like we can
> - * ignore it without any impact.
> - */
> - if (cap_read_drain(iommu->cap))
> - val |= DMA_TLB_READ_DRAIN;
> -#endif
> +
> if (cap_write_drain(iommu->cap))
> val |= DMA_TLB_WRITE_DRAIN;
>
> --
> 2.34.1
>
prev parent reply other threads:[~2023-06-12 18:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 6:05 [PATCH 1/1] iommu/vt-d: Remove commented-out code Lu Baolu
2023-06-12 18:15 ` Jerry Snitselaar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54wdooghiofgutm73l6klmr6kkalwxuw46l3kxqgccwkta3brz@dezrf7rslvl7 \
--to=jsnitsel@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).