From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Richard Acayan <mailingradian@gmail.com>,
linux-arm-msm@vger.kernel.org
Cc: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@chromium.org>,
Sibi Sankar <sibis@codeaurora.org>,
Loic Poulain <loic.poulain@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
iommu@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] iommu: arm-smmu-qcom: add sdm670 compatible
Date: Wed, 21 Sep 2022 20:47:57 +0200 [thread overview]
Message-ID: <5c25dc95-d7a4-0b15-5514-6fe3a48e899c@somainline.org> (raw)
In-Reply-To: <77b7d58f-ba85-86de-8635-6efbb1354a08@linaro.org>
On 21.09.2022 09:31, Krzysztof Kozlowski wrote:
> On 21/09/2022 00:39, Richard Acayan wrote:
>> The Snapdragon 670 needs the IOMMU for GENI I2C. Add a compatible string to
>> support it.
>>
>> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
>> ---
>> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>> index b2708de25ea3..bf9653b9eb89 100644
>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>> @@ -431,6 +431,7 @@ static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
>> { .compatible = "qcom,sc8180x-smmu-500" },
>> { .compatible = "qcom,sc8280xp-smmu-500" },
>> { .compatible = "qcom,sdm630-smmu-v2" },
>> + { .compatible = "qcom,sdm670-smmu-500" },
>
> Why do we keep adding compatibles to the driver for apparently
> compatible devices?
Because Linux has not funny run on bare Qualcomm hardware ever since at least msm8x60 times and
we are not interacting with real hardware, only with Qualcomm's flawed virtual implementation
of it, that's abstracted to us through various generations of their saddening software stack. This
is also the case for many more standard components, even as far as the GIC on recent boards..
Konrad
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-09-21 19:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 22:39 [PATCH 0/2] iommu: SMMU for SDM670 Richard Acayan
2022-09-20 22:39 ` [PATCH 1/2] dt-bindings: iommu: arm-smmu: add sdm670 compatible Richard Acayan
2022-09-21 7:31 ` Krzysztof Kozlowski
2022-09-20 22:39 ` [PATCH 2/2] iommu: arm-smmu-qcom: " Richard Acayan
2022-09-20 23:45 ` Konrad Dybcio
2022-09-21 7:31 ` Krzysztof Kozlowski
2022-09-21 18:47 ` Konrad Dybcio [this message]
2022-09-21 18:48 ` Konrad Dybcio
2022-09-21 19:05 ` Krzysztof Kozlowski
2022-09-21 21:14 ` Konrad Dybcio
2022-09-22 2:38 ` Richard Acayan
2022-09-22 6:41 ` Krzysztof Kozlowski
2022-09-22 10:48 ` Konrad Dybcio
2022-09-22 12:18 ` Krzysztof Kozlowski
2022-09-23 22:24 ` Richard Acayan
2022-09-22 6:39 ` Krzysztof Kozlowski
2022-10-18 10:21 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c25dc95-d7a4-0b15-5514-6fe3a48e899c@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mailingradian@gmail.com \
--cc=quic_saipraka@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sibis@codeaurora.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).