iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>,
	thierry.reding@gmail.com, joro@8bytes.org,
	Maxime Ripard <maxime@cerno.tech>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org, jonathanh@nvidia.com
Subject: Re: [PATCH v4 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device()
Date: Fri, 2 Oct 2020 19:37:11 +0300	[thread overview]
Message-ID: <6018e1c5-9ddd-3e37-1d6b-3feb969a7474@gmail.com> (raw)
In-Reply-To: <3ecfe9ae-fa32-8384-c912-4e17ff5fede7@gmail.com>

02.10.2020 19:00, Dmitry Osipenko пишет:
> 02.10.2020 18:23, Dmitry Osipenko пишет:
>> 02.10.2020 09:08, Nicolin Chen пишет:
>>> Then when a client gets probed, of_iommu_configure() in
>>> iommu core will search DTB for swgroup ID and call ->of_xlate()
>>> to prepare an fwspec, similar to tegra_smmu_probe_device() and
>>> tegra_smmu_configure(). Then it'll call tegra_smmu_probe_device()
>>> again, and this time we shall return smmu->iommu pointer properly.
>>
>> I don't quite see where IOMMU core calls of_xlate().
>>
>> Have tried to at least boot-test this patch?
>>
> 
> I don't see how it ever could work because of_xlate() is only invoked from:
> 
> fsl_mc_dma_configure()->of_dma_configure_id()->of_iommu_configure()
> 
> Looks like the tegra_smmu_configure() is still needed.
> 
> I don't know how sun50i driver could work to be honest. Seems IOMMU is
> broken on sun50i, but maybe I'm missing something.
> 
> I added Maxime Ripard to this thread, who is the author of the
> sun50i-iommu driver.
> 

Actually, I now see that the other IOMMU drivers (qcom, exynos, etc) do
the same. So obviously I'm missing something and it should work..
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2020-10-02 16:37 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02  6:08 [PATCH v4 0/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-10-02  6:08 ` [PATCH v4 1/3] iommu/tegra-smmu: Use fwspec in tegra_smmu_(de)attach_dev Nicolin Chen
2020-10-02 14:22   ` Dmitry Osipenko
2020-10-02 14:52     ` Dmitry Osipenko
2020-10-02 19:56       ` Nicolin Chen
2020-10-02 14:26   ` Dmitry Osipenko
2020-10-02 14:41   ` Dmitry Osipenko
2020-10-02 19:45     ` Nicolin Chen
2020-10-02 20:12       ` Dmitry Osipenko
2020-10-02 23:53         ` Nicolin Chen
2020-10-03  4:01           ` Dmitry Osipenko
2020-10-02  6:08 ` [PATCH v4 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device() Nicolin Chen
2020-10-02 14:22   ` Dmitry Osipenko
2020-10-02 14:58     ` Dmitry Osipenko
2020-10-02 19:53       ` Nicolin Chen
2020-10-05  9:47         ` Thierry Reding
2020-10-02 14:22   ` Dmitry Osipenko
2020-10-02 14:50     ` Dmitry Osipenko
2020-10-05  9:53       ` Thierry Reding
2020-10-05 10:36         ` Dmitry Osipenko
2020-10-05 11:15           ` Thierry Reding
2020-10-05 13:28             ` Dmitry Osipenko
2020-10-05 14:22               ` Thierry Reding
2020-10-05  9:51     ` Thierry Reding
2020-10-02 14:23   ` Dmitry Osipenko
2020-10-02 18:01     ` Nicolin Chen
2020-10-02 18:20       ` Dmitry Osipenko
2020-10-02 15:02   ` Dmitry Osipenko
2020-10-02 18:58     ` Nicolin Chen
2020-10-05  9:57       ` Thierry Reding
2020-10-06  1:05         ` Nicolin Chen
2020-10-08  9:53           ` Thierry Reding
2020-10-08 21:12             ` Nicolin Chen
2020-10-09 12:25               ` Thierry Reding
2020-10-09 15:54                 ` Nicolin Chen
2020-10-02 15:23   ` Dmitry Osipenko
2020-10-02 16:00     ` Dmitry Osipenko
2020-10-02 16:37       ` Dmitry Osipenko [this message]
2020-10-02 16:50         ` Dmitry Osipenko
2020-10-02  6:08 ` [PATCH v4 3/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-10-02 14:35   ` Dmitry Osipenko
2020-10-02 17:45     ` Nicolin Chen
2020-10-02 18:04       ` Dmitry Osipenko
2020-10-02 18:04   ` Dmitry Osipenko
2020-10-05 10:04   ` Thierry Reding
2020-10-06  0:54     ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6018e1c5-9ddd-3e37-1d6b-3feb969a7474@gmail.com \
    --to=digetx@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=nicoleotsuka@gmail.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).