From: Robin Murphy <robin.murphy@arm.com>
To: Barry Song <song.bao.hua@hisilicon.com>,
will@kernel.org, joro@8bytes.org
Cc: iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, prime.zeng@hisilicon.com,
linuxarm@huawei.com
Subject: Re: [PATCH v4 0/3] iommu/arm-smmu-v3: permit users to disable msi polling
Date: Thu, 20 Aug 2020 14:10:04 +0100 [thread overview]
Message-ID: <6215bf9b-e137-ac84-ed8e-f6e8983bb1b1@arm.com> (raw)
In-Reply-To: <20200818233827.21452-1-song.bao.hua@hisilicon.com>
On 2020-08-19 00:38, Barry Song wrote:
> patch 1/3 and patch 2/3 are the preparation of patch 3/3 which permits users
> to disable MSI-based polling by cmd line.
>
> -v4:
> with respect to Robin's comments
> * cleanup the code of the existing module parameter disable_bypass
> * add ARM_SMMU_OPT_MSIPOLL flag. on the other hand, we only need to check
> a bit in options rather than two bits in features
Thanks Barry - for all 3 patches,
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
I'd be inclined to squash #2 into #1, but I'll leave that up to Will.
Cheers,
Robin.
>
> Barry Song (3):
> iommu/arm-smmu-v3: replace symbolic permissions by octal permissions
> for module parameter
> iommu/arm-smmu-v3: replace module_param_named by module_param for
> disable_bypass
> iommu/arm-smmu-v3: permit users to disable msi polling
>
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2020-08-20 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 23:38 [PATCH v4 0/3] iommu/arm-smmu-v3: permit users to disable msi polling Barry Song
2020-08-18 23:38 ` [PATCH v4 1/3] iommu/arm-smmu-v3: replace symbolic permissions by octal permissions for module parameter Barry Song
2020-08-18 23:38 ` [PATCH v4 2/3] iommu/arm-smmu-v3: replace module_param_named by module_param for disable_bypass Barry Song
2020-08-18 23:38 ` [PATCH v4 3/3] iommu/arm-smmu-v3: permit users to disable msi polling Barry Song
2020-08-20 13:10 ` Robin Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6215bf9b-e137-ac84-ed8e-f6e8983bb1b1@arm.com \
--to=robin.murphy@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@hisilicon.com \
--cc=song.bao.hua@hisilicon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).