From: Lu Baolu <baolu.lu@linux.intel.com>
To: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>
Cc: "Raj, Ashok" <ashok.raj@intel.com>,
Will Deacon <will.deacon@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V2 2/5] iommu/vt-d: Rename device_def_domain_type() to intel_iommu_dev_def_domain_type()
Date: Sun, 23 Feb 2020 09:50:37 +0800 [thread overview]
Message-ID: <682f468c-3c16-0a21-c67b-0305545d85fe@linux.intel.com> (raw)
In-Reply-To: <FFF73D592F13FD46B8700F0A279B802F572054FD@ORSMSX114.amr.corp.intel.com>
Hi,
On 2020/2/23 7:59, Prakhya, Sai Praneeth wrote:
>>
>> On 2020/2/17 5:57, Sai Praneeth Prakhya wrote:
>>> The functionality needed for iommu_ops->dev_def_domain_type() is
>>> already provided by device_def_domain_type() in intel_iommu.c. But,
>>> every call back function in intel_iommu_ops starts with intel_iommu
>>> prefix, hence rename
>>> device_def_domain_type() to intel_iommu_dev_def_domain_type() so that
>>> it follows the same semantics.
>>
>> How about keep device_def_domain_type() and call it in the new
>> intel_iommu_dev_def_domain_type()?
>
> Sure! I could but could you please explain the advantages we might get by doing so?
> Less number of changes is what I could think of.. any other reasons?
>
device_def_domain_type() is a quirk list for devices that must use a
specified domain type. intel_iommu_dev_def_domain_type() tells the upper
layer whether the device could switch to another type of domain. Put
them in separated functions will make it easier for maintenance.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-02-23 1:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 21:57 [PATCH V2 0/5] iommu: Add support to change default domain of a group Sai Praneeth Prakhya
2020-02-16 21:57 ` [PATCH V2 1/5] iommu: Add dev_def_domain_type() call back function to iommu_ops Sai Praneeth Prakhya
2020-02-22 23:37 ` Lu Baolu
2020-02-22 23:39 ` Prakhya, Sai Praneeth
2020-02-16 21:57 ` [PATCH V2 2/5] iommu/vt-d: Rename device_def_domain_type() to intel_iommu_dev_def_domain_type() Sai Praneeth Prakhya
2020-02-22 23:42 ` Lu Baolu
2020-02-22 23:59 ` Prakhya, Sai Praneeth
2020-02-23 1:50 ` Lu Baolu [this message]
2020-02-24 3:23 ` Prakhya, Sai Praneeth
2020-02-16 21:57 ` [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group Sai Praneeth Prakhya
2020-02-23 1:20 ` Lu Baolu
2020-02-24 3:20 ` Prakhya, Sai Praneeth
2020-02-24 5:46 ` Lu Baolu
2020-02-24 7:03 ` Prakhya, Sai Praneeth
2020-02-24 7:39 ` Lu Baolu
2020-02-24 7:57 ` Prakhya, Sai Praneeth
2020-02-24 8:12 ` Lu Baolu
2020-02-24 8:39 ` Lu Baolu
2020-02-24 8:44 ` Prakhya, Sai Praneeth
2020-03-02 15:08 ` Joerg Roedel
2020-03-03 6:47 ` Lu Baolu
2020-03-03 13:13 ` Joerg Roedel
2020-03-04 12:17 ` Lu Baolu
2020-02-16 21:57 ` [PATCH V2 4/5] iommu: Take lock before reading iommu_group default domain type Sai Praneeth Prakhya
2020-02-16 21:57 ` [PATCH V2 5/5] iommu: Document usage of "/sys/kernel/iommu_groups/<grp_id>/type" file Sai Praneeth Prakhya
2020-02-23 1:38 ` Lu Baolu
2020-02-24 2:18 ` Prakhya, Sai Praneeth
2020-02-22 23:40 ` [PATCH V2 0/5] iommu: Add support to change default domain of a group Prakhya, Sai Praneeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682f468c-3c16-0a21-c67b-0305545d85fe@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=robin.murphy@arm.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).