From: Lu Baolu <baolu.lu@linux.intel.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Arnd Bergmann <arnd@kernel.org>, Will Deacon <will@kernel.org>,
Hector Martin <marcan@marcan.st>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Alexander Graf <graf@amazon.com>,
Mohamed Mediouni <mohamed.mediouni@caramail.com>,
Robin Murphy <robin.murphy@arm.com>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>
Subject: Re: [PATCH v3 4/6] iommu: Move IOMMU pagesize check to attach_device
Date: Thu, 21 Oct 2021 10:22:30 +0800 [thread overview]
Message-ID: <6a886030-cbc6-9e92-bf79-77b659da2915@linux.intel.com> (raw)
In-Reply-To: <8735ovdbcv.wl-maz@kernel.org>
On 10/20/21 10:22 PM, Marc Zyngier wrote:
> On Wed, 20 Oct 2021 06:21:44 +0100,
> Lu Baolu <baolu.lu@linux.intel.com> wrote:
>>
>> On 2021/10/20 0:37, Sven Peter via iommu wrote:
>>> The iova allocator is capable of handling any granularity which is a power
>>> of two. Remove the much stronger condition that the granularity must be
>>> smaller or equal to the CPU page size from a BUG_ON there.
>>> Instead, check this condition during __iommu_attach_device and fail
>>> gracefully.
>>>
>>> Signed-off-by: Sven Peter<sven@svenpeter.dev>
>>> ---
>>> drivers/iommu/iommu.c | 35 ++++++++++++++++++++++++++++++++---
>>> drivers/iommu/iova.c | 7 ++++---
>>> include/linux/iommu.h | 5 +++++
>>> 3 files changed, 41 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
>>> index dd7863e453a5..28896739964b 100644
>>> --- a/drivers/iommu/iommu.c
>>> +++ b/drivers/iommu/iommu.c
>>> @@ -80,6 +80,8 @@ static struct iommu_domain *__iommu_domain_alloc(struct bus_type *bus,
>>> unsigned type);
>>> static int __iommu_attach_device(struct iommu_domain *domain,
>>> struct device *dev);
>>> +static void __iommu_detach_device(struct iommu_domain *domain,
>>> + struct device *dev);
>>> static int __iommu_attach_group(struct iommu_domain *domain,
>>> struct iommu_group *group);
>>> static void __iommu_detach_group(struct iommu_domain *domain,
>>> @@ -1974,6 +1976,19 @@ void iommu_domain_free(struct iommu_domain *domain)
>>> }
>>> EXPORT_SYMBOL_GPL(iommu_domain_free);
>>> +static int iommu_check_page_size(struct iommu_domain *domain)
>>> +{
>>> + if (!iommu_is_paging_domain(domain))
>>> + return 0;
>>> +
>>> + if (!(domain->pgsize_bitmap & (PAGE_SIZE | (PAGE_SIZE - 1)))) {
>>> + pr_warn("IOMMU pages cannot exactly represent CPU pages.\n");
>>> + return -EFAULT;
>>> + }
>>> +
>>> + return 0;
>>> +}
>>> +
>>> static int __iommu_attach_device(struct iommu_domain *domain,
>>> struct device *dev)
>>> {
>>> @@ -1983,9 +1998,23 @@ static int __iommu_attach_device(struct iommu_domain *domain,
>>> return -ENODEV;
>>> ret = domain->ops->attach_dev(domain, dev);
>>> - if (!ret)
>>> - trace_attach_device_to_domain(dev);
>>> - return ret;
>>> + if (ret)
>>> + return ret;
>>> +
>>> + /*
>>> + * Check that CPU pages can be represented by the IOVA granularity.
>>> + * This has to be done after ops->attach_dev since many IOMMU drivers
>>> + * only limit domain->pgsize_bitmap after having attached the first
>>> + * device.
>>> + */
>>> + ret = iommu_check_page_size(domain);
>>> + if (ret) {
>>> + __iommu_detach_device(domain, dev);
>>> + return ret;
>>> + }
>>
>> It looks odd. __iommu_attach_device() attaches an I/O page table for a
>> device. How does it relate to CPU pages? Why is it a failure case if CPU
>> page size is not covered?
>
> If you allocate a CPU PAGE_SIZE'd region, and point it at a device
> that now can DMA to more than what you have allocated because the
> IOMMU's own page size is larger, the device has now access to data it
> shouldn't see. In my book, that's a pretty bad thing.
But even you enforce the CPU page size check here, this problem still
exists unless all DMA buffers are PAGE_SIZE aligned and sized, right?
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-10-21 2:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 16:37 [PATCH v3 0/6] Support IOMMU page sizes larger than the CPU page size Sven Peter via iommu
2021-10-19 16:37 ` [PATCH v3 1/6] iommu/dma: Disable get_sgtable for granule > PAGE_SIZE Sven Peter via iommu
2021-10-19 16:37 ` [PATCH v3 2/6] iommu/dma: Support granule > PAGE_SIZE in dma_map_sg Sven Peter via iommu
2021-10-19 16:37 ` [PATCH v3 3/6] iommu/dma: Support granule > PAGE_SIZE allocations Sven Peter via iommu
2021-10-19 16:37 ` [PATCH v3 4/6] iommu: Move IOMMU pagesize check to attach_device Sven Peter via iommu
2021-10-20 5:21 ` Lu Baolu
2021-10-20 14:22 ` Marc Zyngier
2021-10-21 2:22 ` Lu Baolu [this message]
2021-10-21 8:10 ` Marc Zyngier
2021-10-22 2:52 ` Lu Baolu
2021-10-22 8:06 ` Marc Zyngier
2021-10-22 13:39 ` Robin Murphy
2021-10-23 8:40 ` Sven Peter via iommu
2021-10-21 8:31 ` Sven Peter via iommu
2021-10-19 16:37 ` [PATCH v3 5/6] iommu: Introduce __IOMMU_DOMAIN_LP Sven Peter via iommu
2021-10-19 16:37 ` [PATCH v3 6/6] iommu/dart: Remove force_bypass logic Sven Peter via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a886030-cbc6-9e92-bf79-77b659da2915@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alyssa@rosenzweig.io \
--cc=arnd@kernel.org \
--cc=graf@amazon.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=mohamed.mediouni@caramail.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).