From: "Lendacky, Thomas" <Thomas.Lendacky@amd.com>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>,
"x86@kernel.org" <x86@kernel.org>
Cc: "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Robin Murphy <robin.murphy@arm.com>,
Mike Anderson <andmike@linux.ibm.com>,
Ram Pai <linuxram@us.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Halil Pasic <pasic@linux.ibm.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 2/6] swiotlb: Remove call to sme_active()
Date: Thu, 18 Jul 2019 17:26:02 +0000 [thread overview]
Message-ID: <7708048b-cc92-debc-54ba-6b3ad353c5bb@amd.com> (raw)
In-Reply-To: <20190718032858.28744-3-bauerman@linux.ibm.com>
On 7/17/19 10:28 PM, Thiago Jung Bauermann wrote:
> sme_active() is an x86-specific function so it's better not to call it from
> generic code.
>
> There's no need to mention which memory encryption feature is active, so
> just use a more generic message. Besides, other architectures will have
> different names for similar technology.
>
> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> kernel/dma/swiotlb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 62fa5a82a065..e52401f94e91 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -459,8 +459,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
> panic("Can not allocate SWIOTLB buffer earlier and can't now provide you with the DMA bounce buffer");
>
> if (mem_encrypt_active())
> - pr_warn_once("%s is active and system is using DMA bounce buffers\n",
> - sme_active() ? "SME" : "SEV");
> + pr_warn_once("Memory encryption is active and system is using DMA bounce buffers\n");
>
> mask = dma_get_seg_boundary(hwdev);
>
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-07-18 17:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 3:28 [PATCH v3 0/6] Remove x86-specific code from generic headers Thiago Jung Bauermann
2019-07-18 3:28 ` [PATCH v3 1/6] x86, s390: Move ARCH_HAS_MEM_ENCRYPT definition to arch/Kconfig Thiago Jung Bauermann
2019-07-18 3:28 ` [PATCH v3 2/6] swiotlb: Remove call to sme_active() Thiago Jung Bauermann
2019-07-18 8:42 ` Christoph Hellwig
2019-07-18 17:26 ` Lendacky, Thomas [this message]
2019-07-18 3:28 ` [PATCH v3 3/6] dma-mapping: Remove dma_check_mask() Thiago Jung Bauermann
2019-07-18 8:42 ` Christoph Hellwig
2019-07-18 17:29 ` Lendacky, Thomas
2019-07-18 3:28 ` [PATCH v3 4/6] x86, s390/mm: Move sme_active() and sme_me_mask to x86-specific header Thiago Jung Bauermann
2019-07-18 8:42 ` [PATCH v3 4/6] x86,s390/mm: " Christoph Hellwig
2019-07-18 17:42 ` [PATCH v3 4/6] x86, s390/mm: " Lendacky, Thomas
2019-07-18 17:56 ` [PATCH v3 4/6] x86,s390/mm: " Christoph Hellwig
2019-07-18 3:28 ` [PATCH v3 5/6] fs/core/vmcore: Move sev_active() reference to x86 arch code Thiago Jung Bauermann
2019-07-18 8:44 ` Christoph Hellwig
2019-07-18 17:47 ` Lendacky, Thomas
2019-07-19 4:59 ` lijiang
2019-07-19 15:47 ` Thiago Jung Bauermann
2019-07-18 3:28 ` [PATCH v3 6/6] s390/mm: Remove sev_active() function Thiago Jung Bauermann
2019-07-18 8:44 ` Christoph Hellwig
2019-07-18 13:01 ` Halil Pasic
2019-07-18 16:43 ` Thiago Jung Bauermann
2019-07-18 16:41 ` Thiago Jung Bauermann
2019-07-18 17:48 ` [PATCH v3 0/6] Remove x86-specific code from generic headers Lendacky, Thomas
2019-07-18 19:44 ` Thiago Jung Bauermann
2019-07-19 13:12 ` Lendacky, Thomas
2019-07-19 15:45 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7708048b-cc92-debc-54ba-6b3ad353c5bb@amd.com \
--to=thomas.lendacky@amd.com \
--cc=adobriyan@gmail.com \
--cc=andmike@linux.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=bp@alien8.de \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=mingo@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).