From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE065C64E7A for ; Tue, 1 Dec 2020 15:27:41 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17DFA2084C for ; Tue, 1 Dec 2020 15:27:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17DFA2084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id BAFA88647F; Tue, 1 Dec 2020 15:27:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2jeE52ydmXLf; Tue, 1 Dec 2020 15:27:38 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5B55486469; Tue, 1 Dec 2020 15:27:38 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 47B5AC1833; Tue, 1 Dec 2020 15:27:38 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 146C7C0859 for ; Tue, 1 Dec 2020 12:54:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 04FB82E128 for ; Tue, 1 Dec 2020 12:54:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ohd+mRaCi9Vl for ; Tue, 1 Dec 2020 12:54:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by silver.osuosl.org (Postfix) with ESMTPS id A628B2E0DC for ; Tue, 1 Dec 2020 12:54:06 +0000 (UTC) Received: from dggeme707-chm.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Clhq314KJz13Kw9; Tue, 1 Dec 2020 20:53:19 +0800 (CST) Received: from dggemi754-chm.china.huawei.com (10.1.198.140) by dggeme707-chm.china.huawei.com (10.1.199.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Tue, 1 Dec 2020 20:54:03 +0800 Received: from dggemi754-chm.china.huawei.com ([10.1.198.140]) by dggemi754-chm.china.huawei.com ([10.1.198.140]) with mapi id 15.01.1913.007; Tue, 1 Dec 2020 20:54:02 +0800 From: wangxingang To: "eric.auger@redhat.com" Subject: Re: [PATCH v13 07/15] iommu/smmuv3: Allow stage 1 invalidation with unmanaged ASIDs Thread-Topic: Re: [PATCH v13 07/15] iommu/smmuv3: Allow stage 1 invalidation with unmanaged ASIDs Thread-Index: AdbH3fUbMyyThiPFQMygEVWlNRJFKg== Date: Tue, 1 Dec 2020 12:54:02 +0000 Message-ID: <79530f9bac8d49448ba871586e1c6c4b@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.185.226] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mailman-Approved-At: Tue, 01 Dec 2020 15:27:37 +0000 Cc: Xieyingtai , "jean-philippe@linaro.org" , "kvm@vger.kernel.org" , "vivek.gautam@arm.com" , "maz@kernel.org" , "will@kernel.org" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "alex.williamson@redhat.com" , "zhangfei.gao@linaro.org" , "robin.murphy@arm.com" , "kvmarm@lists.cs.columbia.edu" , "eric.auger.pro@gmail.com" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3078254442710533140==" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" --===============3078254442710533140== Content-Language: zh-CN Content-Type: multipart/alternative; boundary="_000_79530f9bac8d49448ba871586e1c6c4bhuaweicom_" --_000_79530f9bac8d49448ba871586e1c6c4bhuaweicom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Eric On Wed, 18 Nov 2020 12:21:43, Eric Auger wrote: >@@ -1710,7 +1710,11 @@ static void arm_smmu_tlb_inv_context(void *cookie) > * insertion to guarantee those are observed before the TLBI. Do be > * careful, 007. > */ >- if (smmu_domain->stage =3D=3D ARM_SMMU_DOMAIN_S1) { >+ if (ext_asid >=3D 0) { /* guest stage 1 invalidation */ >+ cmd.opcode =3D CMDQ_OP_TLBI_NH_ASID; >+ cmd.tlbi.asid =3D ext_asid; >+ cmd.tlbi.vmid =3D smmu_domain->s2_cfg.vmid; >+ } else if (smmu_domain->stage =3D=3D ARM_SMMU_DOMAIN_S1) { Found a problem here, the cmd for guest stage 1 invalidation is built, but it is not delivered to smmu. --_000_79530f9bac8d49448ba871586e1c6c4bhuaweicom_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Eric

 

On  Wed, 18 Nov 2020 12:21= :43, Eric Auger wrote:

>@@ -1710,7 +1710,11 @@ = static void arm_smmu_tlb_inv_context(void *cookie)

>      &= nbsp;* insertion to guarantee those are observed before the TLBI. Do be

>      &= nbsp;* careful, 007.

>      &= nbsp;*/

>-    &n= bsp; if (smmu_domain->stage =3D=3D ARM_SMMU_DOMAIN_S1) {

>+   &nbs= p; if (ext_asid >=3D 0) { /* guest stage 1 invalidation */

>+   &nbs= p;          cmd.opcode &n= bsp;   =3D CMDQ_OP_TLBI_NH_ASID;

>+   &nbs= p;          cmd.tlbi.asid = ;   =3D ext_asid;

>+   &nbs= p;          cmd.tlbi.vmid = ;  =3D smmu_domain->s2_cfg.vmid;

>+   &nbs= p; } else if (smmu_domain->stage =3D=3D ARM_SMMU_DOMAIN_S1) {=

 

Found a problem here, the cmd f= or guest stage 1 invalidation is built,

but it is not delivered to smmu= .

--_000_79530f9bac8d49448ba871586e1c6c4bhuaweicom_-- --===============3078254442710533140== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu --===============3078254442710533140==--