From: Lu Baolu <baolu.lu@linux.intel.com>
To: Tom Murphy <murphyt7@tcd.ie>, iommu@lists.linux-foundation.org
Cc: David Woodhouse <dwmw2@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 4/5] iommu/vt-d: Convert intel iommu driver to the iommu ops
Date: Wed, 9 Sep 2020 09:59:11 +0800 [thread overview]
Message-ID: <7b0c0f62-2efa-8183-0cbc-6028feb8ec93@linux.intel.com> (raw)
In-Reply-To: <20200903201839.7327-5-murphyt7@tcd.ie>
On 9/4/20 4:18 AM, Tom Murphy wrote:
> +static int intel_iommu_needs_bounce_buffer(struct device *d)
> +{
> + return !intel_no_bounce && dev_is_pci(d) && to_pci_dev(d)->untrusted;
> +}
> +
> +
> static void intel_iommu_probe_finalize(struct device *dev)
> {
> - struct iommu_domain *domain;
> + dma_addr_t base = IOVA_START_PFN << VTD_PAGE_SHIFT;
> + struct iommu_domain *domain = iommu_get_domain_for_dev(dev);
> + struct dmar_domain *dmar_domain = to_dmar_domain(domain);
>
> - domain = iommu_get_domain_for_dev(dev);
> - if (device_needs_bounce(dev))
> - set_dma_ops(dev, &bounce_dma_ops);
> - else if (domain && domain->type == IOMMU_DOMAIN_DMA)
> - set_dma_ops(dev, &intel_dma_ops);
> + if (intel_iommu_needs_bounce_buffer(dev) ||
For untrusted devices, the DMA type of domain is enforced. There's no
need to check again here.
Best regards,
baolu
> + (domain && domain->type == IOMMU_DOMAIN_DMA))
> + iommu_setup_dma_ops(dev, base,
> + __DOMAIN_MAX_ADDR(dmar_domain->gaw) - base);
> else
> set_dma_ops(dev, NULL);
> }
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-09-09 2:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 20:18 [PATCH V2 0/5] Convert the intel iommu driver to the dma-iommu api Tom Murphy
2020-09-03 20:18 ` [PATCH V2 1/5] iommu: Handle freelists when using deferred flushing in iommu drivers Tom Murphy
2020-09-03 20:18 ` [PATCH V2 2/5] iommu: Add iommu_dma_free_cpu_cached_iovas function Tom Murphy
2020-09-09 0:45 ` Lu Baolu
2020-09-09 7:05 ` Christoph Hellwig
2020-09-12 2:55 ` Lu Baolu
2020-09-03 20:18 ` [PATCH V2 3/5] iommu: allow the dma-iommu api to use bounce buffers Tom Murphy
2020-09-09 1:34 ` Lu Baolu
2020-09-03 20:18 ` [PATCH V2 4/5] iommu/vt-d: Convert intel iommu driver to the iommu ops Tom Murphy
2020-09-09 1:59 ` Lu Baolu [this message]
2020-09-03 20:18 ` [PATCH V2 5/5] DO NOT MERGE: iommu: disable list appending in dma-iommu Tom Murphy
2020-09-07 7:00 ` Christoph Hellwig
2020-09-07 20:18 ` Tom Murphy
2020-09-08 5:36 ` Christoph Hellwig
2020-09-08 5:55 ` Christoph Hellwig
2020-09-08 6:04 ` Lu Baolu
2020-09-08 6:23 ` Christoph Hellwig
2020-09-08 9:07 ` Lu Baolu
2020-09-09 1:43 ` Lu Baolu
2020-09-09 7:06 ` Christoph Hellwig
2020-09-12 3:13 ` Lu Baolu
2020-09-04 10:03 ` [PATCH V2 0/5] Convert the intel iommu driver to the dma-iommu api Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b0c0f62-2efa-8183-0cbc-6028feb8ec93@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=murphyt7@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).