From: Lu Baolu <baolu.lu@linux.intel.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>, linux-kernel@vger.kernel.org
Cc: iommu@lists.linux-foundation.org, Joerg Roedel <jroedel@suse.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] iommu/vt-d: Allocate reserved region for ISA with correct permission
Date: Sun, 15 Dec 2019 13:38:20 +0800 [thread overview]
Message-ID: <7f109c98-00d5-d66c-05c7-70eb670bd1a2@linux.intel.com> (raw)
In-Reply-To: <5ccaaec0-b070-b820-cebd-6b7ad179109c@linux.intel.com>
Hi Jerry,
On 12/14/19 9:42 AM, Lu Baolu wrote:
> Hi Jerry,
>
> On 12/13/19 1:36 PM, Jerry Snitselaar wrote:
>> Currently the reserved region for ISA is allocated with no
>> permissions. If a dma domain is being used, mapping this region will
>> fail. Set the permissions to DMA_PTE_READ|DMA_PTE_WRITE.
>>
>> Cc: Joerg Roedel <jroedel@suse.de>
>> Cc: Lu Baolu <baolu.lu@linux.intel.com>
>> Cc: iommu@lists.linux-foundation.org
>> Cc: stable@vger.kernel.org # v5.3+
>> Fixes: d850c2ee5fe2 ("iommu/vt-d: Expose ISA direct mapping region via
>> iommu_get_resv_regions")
>> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
>> ---
>> drivers/iommu/intel-iommu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
>> index 0c8d81f56a30..998529cebcf2 100644
>> --- a/drivers/iommu/intel-iommu.c
>> +++ b/drivers/iommu/intel-iommu.c
>> @@ -5736,7 +5736,7 @@ static void intel_iommu_get_resv_regions(struct
>> device *device,
>> struct pci_dev *pdev = to_pci_dev(device);
>> if ((pdev->class >> 8) == PCI_CLASS_BRIDGE_ISA) {
>> - reg = iommu_alloc_resv_region(0, 1UL << 24, 0,
>> + reg = iommu_alloc_resv_region(0, 1UL << 24, prot,
>> IOMMU_RESV_DIRECT);
>
>
> This also applies to the IOAPIC range. Can you please change them
> together?
Please ignore this comment. These two ranges are of different type. Your
fix is enough. Sorry for the confusion.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-12-15 5:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 5:36 [PATCH] iommu/vt-d: Allocate reserved region for ISA with correct permission Jerry Snitselaar
2019-12-14 1:42 ` Lu Baolu
2019-12-15 5:38 ` Lu Baolu [this message]
2019-12-15 5:39 ` Lu Baolu
2019-12-17 10:48 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f109c98-00d5-d66c-05c7-70eb670bd1a2@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=jsnitsel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).