From: Matthias Brugger <matthias.bgg@gmail.com>
To: Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>,
Jiri Kosina <trivial@kernel.org>
Cc: linux-fbdev@vger.kernel.org, oss-drivers@netronome.com,
nouveau@lists.freedesktop.org,
alsa-devel <alsa-devel@alsa-project.org>,
dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org,
linux-ide@vger.kernel.org, dm-devel@redhat.com,
linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org,
sparclinux@vger.kernel.org, linux-afs@lists.infradead.org,
linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, dccp@vger.kernel.org,
linux-rdma@vger.kernel.org,
linux-atm-general@lists.sourceforge.net,
kvmarm@lists.cs.columbia.edu, coreteam@netfilter.org,
intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org,
linux-input@vger.kernel.org, linux-mmc@vger.kernel.org,
Kees Cook <kees.cook@canonical.com>,
linux-media@vger.kernel.org, linux-pm@vger.kernel.org,
intel-gfx@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-nvme@lists.infradead.org, storagedev@microchip.com,
ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Nick Desaulniers <ndesaulniers@google.com>,
linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-sctp@vger.kernel.org,
iommu@lists.linux-foundation.org,
netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org,
bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;
Date: Thu, 10 Sep 2020 12:16:33 +0200 [thread overview]
Message-ID: <81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com> (raw)
In-Reply-To: <e6387578c75736d61b2fe70d9783d91329a97eb4.camel@perches.com>
On 09/09/2020 22:06, Joe Perches wrote:
> diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c
> index 09f931d4598c..778be26d329f 100644
> --- a/drivers/net/wireless/mediatek/mt7601u/dma.c
> +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c
> @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb)
> case -ESHUTDOWN:
> case -ENOENT:
> return;
> + case 0:
> + break;
> default:
> dev_err_ratelimited(dev->dev, "rx urb failed: %d\n",
> urb->status);
> - fallthrough;
> - case 0:
> break;
> }
>
> @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb)
> case -ESHUTDOWN:
> case -ENOENT:
> return;
> + case 0:
> + break;
> default:
> dev_err_ratelimited(dev->dev, "tx urb failed: %d\n",
> urb->status);
> - fallthrough;
> - case 0:
> break;
> }
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-09-10 10:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 20:06 [trivial PATCH] treewide: Convert switch/case fallthrough; to break; Joe Perches
2020-09-09 20:38 ` Gustavo A. R. Silva
2020-09-09 20:55 ` Keith Busch
2020-09-17 19:40 ` Jacob Keller
2020-09-09 22:36 ` Jason Gunthorpe
2020-09-09 22:47 ` Joe Perches
2020-09-10 6:28 ` Mauro Carvalho Chehab
2020-09-10 6:53 ` Wolfram Sang
2020-09-10 8:24 ` Nicolas.Ferre--- via iommu
2020-09-10 8:47 ` Felipe Balbi
2020-09-10 9:18 ` Steffen Maier
2020-09-10 9:24 ` Ilya Dryomov
2020-09-10 10:16 ` Matthias Brugger [this message]
2020-09-10 14:21 ` Robin Murphy
2020-09-11 4:19 ` Joe Perches
2020-09-15 9:06 ` [Intel-gfx] " Jani Nikula
2020-09-15 9:19 ` Miquel Raynal
2020-09-17 8:03 ` [oss-drivers] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81d852d4-115f-c6c6-ef80-17c47ec4849a@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=bpf@vger.kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=dccp@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joe@perches.com \
--cc=kees.cook@canonical.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-afs@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=oss-drivers@netronome.com \
--cc=sparclinux@vger.kernel.org \
--cc=storagedev@microchip.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).