From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C554DC49ED7 for ; Fri, 20 Sep 2019 07:54:12 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 875EE222CE for ; Fri, 20 Sep 2019 07:54:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="iNg4yCYi"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="PZH5MrZC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 875EE222CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 4B249AE0; Fri, 20 Sep 2019 07:54:12 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 36B6A40B for ; Fri, 20 Sep 2019 07:54:11 +0000 (UTC) Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D65F686E for ; Fri, 20 Sep 2019 07:54:10 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AC3996155C; Fri, 20 Sep 2019 07:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568966050; bh=J9ixUqe5hZvgjP3d9E63RycwkbxkMnQGaECw4yn9tE4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iNg4yCYi6nJvVA7VKDGqgcKKIDXxTT+DAjnQ29dJ7SLbcCZFy1/MJv215C6R0U282 Cpb714yrWX3K6J5vBTTkQ/W5GOY3FGy8tDHaxPP/xp80BMpXVuSBmyUNTS+ZO6qCrh ESCvMEcV8MCRirvsZ2wH2Mb4dtHB2R5X297BMdc4= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 8B7E5602E1; Fri, 20 Sep 2019 07:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568966049; bh=J9ixUqe5hZvgjP3d9E63RycwkbxkMnQGaECw4yn9tE4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PZH5MrZCqbyeRs8OOxV425gJhjvxUQcZ3azcX7C8eV93q9fb6y8xYdtulKffI9moP m0zXJLnolr2rGQV0B3mIN0+FWGJ6VKNCJ1txtvuoH9d9e3LPwBmTawVm+udTcyEPdw H4Ku1Qn3VfL+Vq/2+H8BYLW3c+NgepdxerLO5JFU= MIME-Version: 1.0 Date: Fri, 20 Sep 2019 13:24:09 +0530 From: Sai Prakash Ranjan To: Stephen Boyd Subject: Re: [PATCHv6 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook In-Reply-To: <5d83de74.1c69fb81.71c0f.f162@mx.google.com> References: <1513424ecec891d19c1aa3c599ec67db7964b6b2.1568712606.git.saiprakash.ranjan@codeaurora.org> <20190919002501.GA20859@builder> <081fff2f5dacfa7b6f5df6364f088045@codeaurora.org> <5d83de74.1c69fb81.71c0f.f162@mx.google.com> Message-ID: <8268c9b4002f6b9b1c87fcc16920f57f@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Cc: Rajendra Nayak , Robin Murphy , linux-kernel@vger.kernel.org, Bjorn Andersson , iommu@lists.linux-foundation.org, Andy Gross , linux-arm-msm@vger.kernel.org, Will Deacon , linux-arm-msm-owner@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On 2019-09-20 01:30, Stephen Boyd wrote: > Quoting Sai Prakash Ranjan (2019-09-19 11:54:27) >> On 2019-09-19 08:48, Sai Prakash Ranjan wrote: >> > On 2019-09-19 05:55, Bjorn Andersson wrote: >> >> In the transition to this new design we lost the ability to >> >> enable/disable the safe toggle per board, which according to Vivek >> >> would result in some issue with Cheza. >> >> >> >> Can you confirm that this is okay? (Or introduce the DT property for >> >> enabling the safe_toggle logic?) >> >> >> > >> > Hmm, I don't remember Vivek telling about any issue on Cheza because >> > of this logic. >> > But I will test this on Cheza and let you know. >> > >> >> I tested this on Cheza and no perf degradation nor any other issue is >> seen >> atleast openly, although I see this below stack dump always with >> cant_sleep change added. > > The usage of cant_sleep() here is wrong then, and the comment should be > removed from the scm API as well because it looks like it's perfectly > OK > to call the function from a context that can sleep. > Looking more into this downstream, it says this *can be called in atomic context* and not *should be called only in atomic context*. So will remove cant_sleep and modify the comment accordingly. -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu