From: Kunkun Jiang <jiangkunkun@huawei.com>
To: Will Deacon <will@kernel.org>
Cc: Keqian Zhu <zhukeqian1@huawei.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
wanghaibin.wang@huawei.com, Robin Murphy <robin.murphy@arm.com>,
"moderated list:ARM SMMU DRIVERS"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] iommu/io-pgtalbe-arm: Remove "iopte_type(pte, l)" extra parameter "l"
Date: Mon, 7 Dec 2020 20:09:54 +0800 [thread overview]
Message-ID: <83f3f9f5-43d8-e02b-39e2-70edd42799a8@huawei.com> (raw)
In-Reply-To: <20201207102458.GB3825@willie-the-truck>
Hi Will,
On 2020/12/7 18:24, Will Deacon wrote:
> On Mon, Dec 07, 2020 at 04:14:04PM +0800, Kunkun Jiang wrote:
>> Knowing from the code, the macro "iopte_type(pte, l)" doesn't use the
>> parameter "l" (level). So we'd better to remove it.
>>
>> Fixes: e1d3c0fd701df(iommu: add ARM LPAE page table allocator)
>> Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
>> ---
>> drivers/iommu/io-pgtable-arm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c
>> index a7a9bc08dcd1..925ae2b713d6 100644
>> --- a/drivers/iommu/io-pgtable-arm.c
>> +++ b/drivers/iommu/io-pgtable-arm.c
>> @@ -130,7 +130,7 @@
>> /* IOPTE accessors */
>> #define iopte_deref(pte,d) __va(iopte_to_paddr(pte, d))
>>
>> -#define iopte_type(pte,l) \
>> +#define iopte_type(pte) \
>> (((pte) >> ARM_LPAE_PTE_TYPE_SHIFT) & ARM_LPAE_PTE_TYPE_MASK)
> Shouldn't we update all the users of the macro too?
>
> Will
> .
Sorry for my carelessness. :(
I have resent it.
Thanks,
Kunkun Jiang
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2020-12-07 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 8:14 [PATCH] iommu/io-pgtalbe-arm: Remove "iopte_type(pte, l)" extra parameter "l" Kunkun Jiang
2020-12-07 10:24 ` Will Deacon
2020-12-07 12:09 ` Kunkun Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83f3f9f5-43d8-e02b-39e2-70edd42799a8@huawei.com \
--to=jiangkunkun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=wanghaibin.wang@huawei.com \
--cc=will@kernel.org \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).