From: Randy Dunlap <rdunlap@infradead.org>
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/1] iommu/vt-d: Fix compile error [-Werror=implicit-function-declaration]
Date: Sat, 30 Jan 2021 09:42:41 -0800 [thread overview]
Message-ID: <84803c36-c29c-09a2-8731-af85ffdf26aa@infradead.org> (raw)
In-Reply-To: <20210130151907.3929148-1-baolu.lu@linux.intel.com>
On 1/30/21 7:19 AM, Lu Baolu wrote:
> trace_qi_submit() could be used when interrupt remapping is supported,
> but DMA remapping is not. In this case, the following compile error
> occurs.
>
> ../drivers/iommu/intel/dmar.c: In function 'qi_submit_sync':
> ../drivers/iommu/intel/dmar.c:1311:3: error: implicit declaration of function 'trace_qi_submit';
> did you mean 'ftrace_nmi_exit'? [-Werror=implicit-function-declaration]
> trace_qi_submit(iommu, desc[i].qw0, desc[i].qw1,
> ^~~~~~~~~~~~~~~
> ftrace_nmi_exit
>
> Fixes: f2dd871799ba5 ("iommu/vt-d: Add qi_submit trace event")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/iommu/intel/Makefile | 2 +-
> drivers/iommu/intel/iommu.c | 1 -
> include/trace/events/intel_iommu.h | 2 --
> 3 files changed, 1 insertion(+), 4 deletions(-)
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
--
~Randy
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-01-30 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 15:19 [PATCH 1/1] iommu/vt-d: Fix compile error [-Werror=implicit-function-declaration] Lu Baolu
2021-01-30 17:42 ` Randy Dunlap [this message]
2021-02-02 13:44 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84803c36-c29c-09a2-8731-af85ffdf26aa@infradead.org \
--to=rdunlap@infradead.org \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).