From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, Tom Murphy <murphyt7@tcd.ie>,
David Woodhouse <dwmw2@infradead.org>,
Christoph Hellwig <hch@infradead.org>
Cc: Intel-gfx@lists.freedesktop.org,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Ashok Raj <ashok.raj@intel.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/7] Convert the intel iommu driver to the dma-iommu api
Date: Tue, 3 Nov 2020 09:14:32 +0000 [thread overview]
Message-ID: <99a0d1eb-7fde-dff4-225f-92b68fbf7620@linux.intel.com> (raw)
In-Reply-To: <82dab98e-0761-8946-c31c-92f19a0615b4@linux.intel.com>
On 03/11/2020 02:53, Lu Baolu wrote:
> On 11/2/20 7:52 PM, Tvrtko Ursulin wrote:
>>
>> On 02/11/2020 02:00, Lu Baolu wrote:
>>> Hi Tvrtko,
>>> On 10/12/20 4:44 PM, Tvrtko Ursulin wrote:
>>>>
>>>> On 29/09/2020 01:11, Lu Baolu wrote:
>>>>> Hi Tvrtko,
>>>>>
>>>>> On 9/28/20 5:44 PM, Tvrtko Ursulin wrote:
>>>>>>
>>>>>> On 27/09/2020 07:34, Lu Baolu wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> The previous post of this series could be found here.
>>>>>>>
>>>>>>> https://lore.kernel.org/linux-iommu/20200912032200.11489-1-baolu.lu@linux.intel.com/
>>>>>>>
>>>>>>>
>>>>>>> This version introduce a new patch [4/7] to fix an issue reported
>>>>>>> here.
>>>>>>>
>>>>>>> https://lore.kernel.org/linux-iommu/51a1baec-48d1-c0ac-181b-1fba92aa428d@linux.intel.com/
>>>>>>>
>>>>>>>
>>>>>>> There aren't any other changes.
>>>>>>>
>>>>>>> Please help to test and review.
>>>>>>>
>>>>>>> Best regards,
>>>>>>> baolu
>>>>>>>
>>>>>>> Lu Baolu (3):
>>>>>>> iommu: Add quirk for Intel graphic devices in map_sg
>>>>>>
>>>>>> Since I do have patches to fix i915 to handle this, do we want to
>>>>>> co-ordinate the two and avoid having to add this quirk and then
>>>>>> later remove it? Or you want to go the staged approach?
>>>>>
>>>>> I have no preference. It depends on which patch goes first. Let the
>>>>> maintainers help here.
>>>>
>>>> FYI we have merged the required i915 patches to out tree last week
>>>> or so. I *think* this means they will go into 5.11. So the i915
>>>> specific workaround patch will not be needed in Intel IOMMU.
>>>
>>> Do you mind telling me what's the status of this fix patch? I tried this
>>> series on v5.10-rc1 with the graphic quirk patch dropped. I am still
>>> seeing dma faults from graphic device.
>>
>> Hmm back then I thought i915 fixes for this would land in 5.11 so I
>> will stick with that. :) (See my quoted text a paragraph above yours.)
>
> What size are those fixes? I am considering pushing this series for
> v5.11. Is it possible to get some acks for those patches and let them
> go to Linus through iommu tree?
For 5.10 you mean? They feel a bit too large for comfort to go via a
non-i915/drm tree. These are the two patches required:
https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-gt-next&id=8a473dbadccfc6206150de3db3223c40785da348
https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-gt-next&id=934941ed5a3070a7833c688c9b1d71484fc01a68
I'll copy Joonas as our maintainer - how does the idea of taking the
above two patches through the iommu tree sound to you?
Regards,
Tvrtko
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-11-03 9:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 6:34 [PATCH v4 0/7] Convert the intel iommu driver to the dma-iommu api Lu Baolu
2020-09-27 6:34 ` [PATCH v4 1/7] iommu: Handle freelists when using deferred flushing in iommu drivers Lu Baolu
2020-09-27 6:34 ` [PATCH v4 2/7] iommu: Add iommu_dma_free_cpu_cached_iovas() Lu Baolu
2020-09-27 6:34 ` [PATCH v4 3/7] iommu: Allow the dma-iommu api to use bounce buffers Lu Baolu
2020-09-27 6:34 ` [PATCH v4 4/7] iommu: Add quirk for Intel graphic devices in map_sg Lu Baolu
2020-11-03 12:00 ` Robin Murphy
2020-09-27 6:34 ` [PATCH v4 5/7] iommu/vt-d: Update domain geometry in iommu_ops.at(de)tach_dev Lu Baolu
2020-09-27 6:34 ` [PATCH v4 6/7] iommu/vt-d: Convert intel iommu driver to the iommu ops Lu Baolu
2020-09-27 6:34 ` [PATCH v4 7/7] iommu/vt-d: Cleanup after converting to dma-iommu ops Lu Baolu
2020-09-28 9:44 ` [PATCH v4 0/7] Convert the intel iommu driver to the dma-iommu api Tvrtko Ursulin
2020-09-29 0:11 ` Lu Baolu
2020-10-01 12:17 ` Joerg Roedel
2020-10-02 11:59 ` Lu Baolu
2020-10-12 8:44 ` Tvrtko Ursulin
2020-10-13 0:32 ` Lu Baolu
2020-11-02 2:00 ` Lu Baolu
2020-11-02 11:52 ` Tvrtko Ursulin
2020-11-03 2:53 ` Lu Baolu
2020-11-03 9:14 ` Tvrtko Ursulin [this message]
2020-11-03 9:58 ` Joonas Lahtinen
2020-11-03 10:54 ` Joerg Roedel
2020-11-20 10:20 ` Lu Baolu
2020-10-01 21:17 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a0d1eb-7fde-dff4-225f-92b68fbf7620@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=murphyt7@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).