iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Sven Peter via iommu <iommu@lists.linux-foundation.org>
To: "Rob Herring" <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>,
	Will Deacon <will@kernel.org>, Hector Martin <marcan@marcan.st>,
	linux-kernel@vger.kernel.org,
	Petr Mladek via iommu <iommu@lists.linux-foundation.org>,
	Alexander Graf <graf@amazon.com>, Marc Zyngier <maz@kernel.org>,
	Mohamed Mediouni <mohamed.mediouni@caramail.com>,
	Mark Kettenis <mark.kettenis@xs4all.nl>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Stan Skowronek <stan@corellium.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: iommu: add DART iommu bindings
Date: Sat, 12 Jun 2021 14:24:55 +0200	[thread overview]
Message-ID: <9b226219-bf87-4fd4-8d99-9436861ca3cf@www.fastmail.com> (raw)
In-Reply-To: <20210610165244.GA1948260@robh.at.kernel.org>

Hi,

On Thu, Jun 10, 2021, at 18:52, Rob Herring wrote:
> On Thu, Jun 03, 2021 at 10:50:02AM +0200, Sven Peter wrote:
> > +
> > +examples:
> > +  - |+
> > +    dart1: iommu@82f80000 {
> > +      compatible = "apple,t8103-dart";
> > +      reg = <0x82f80000 0x4000>;
> > +      interrupts = <1 781 4>;
> > +      #iommu-cells = <1>;
> > +    };
> > +
> > +    master1 {
> > +      iommus = <&{/dart1} 0>;
> 
> /dart1 is a path, but 'dart1' is a label. You need '&dart1' (or 
> '&{/iommu@82f80000}' but that doesn't really work here because the 
> examples get prefixed with /example-n/...)
> 
> With that fixed,
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Makes sense, thanks for the review!
Fixed for the next version.


Sven
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-06-12 12:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  8:50 [PATCH v3 0/3] Apple M1 DART IOMMU driver Sven Peter via iommu
2021-06-03  8:50 ` [PATCH v3 1/3] iommu: io-pgtable: add DART pagetable format Sven Peter via iommu
2021-06-03  8:50 ` [PATCH v3 2/3] dt-bindings: iommu: add DART iommu bindings Sven Peter via iommu
2021-06-10 16:52   ` Rob Herring
2021-06-12 12:24     ` Sven Peter via iommu [this message]
2021-06-03  8:50 ` [PATCH v3 3/3] iommu: dart: Add DART iommu driver Sven Peter via iommu
2021-06-05 11:50   ` Rouven Czerwinski
2021-06-05 12:28     ` Sven Peter via iommu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b226219-bf87-4fd4-8d99-9436861ca3cf@www.fastmail.com \
    --to=iommu@lists.linux-foundation.org \
    --cc=arnd@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=graf@amazon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=mark.kettenis@xs4all.nl \
    --cc=maz@kernel.org \
    --cc=mohamed.mediouni@caramail.com \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=stan@corellium.com \
    --cc=sven@svenpeter.dev \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).