From: Lu Baolu <baolu.lu@linux.intel.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc: Kevin Tian <kevin.tian@intel.com>,
David Woodhouse <dwmw2@infradead.org>,
stable@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Gonglei <arei.gonglei@huawei.com>
Subject: Re: [PATCH] iommu/vt-d: Force to flush iotlb before creating superpage
Date: Fri, 2 Apr 2021 12:44:02 +0800 [thread overview]
Message-ID: <9c368419-6e45-6b27-0f34-26b581589fa7@linux.intel.com> (raw)
In-Reply-To: <20210401071834.1639-1-longpeng2@huawei.com>
Hi Longpeng,
On 4/1/21 3:18 PM, Longpeng(Mike) wrote:
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index ee09323..cbcb434 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -2342,9 +2342,20 @@ static inline int hardware_largepage_caps(struct dmar_domain *domain,
> * removed to make room for superpage(s).
> * We're adding new large pages, so make sure
> * we don't remove their parent tables.
> + *
> + * We also need to flush the iotlb before creating
> + * superpage to ensure it does not perserves any
> + * obsolete info.
> */
> - dma_pte_free_pagetable(domain, iov_pfn, end_pfn,
> - largepage_lvl + 1);
> + if (dma_pte_present(pte)) {
The dma_pte_free_pagetable() clears a batch of PTEs. So checking current
PTE is insufficient. How about removing this check and always performing
cache invalidation?
> + int i;
> +
> + dma_pte_free_pagetable(domain, iov_pfn, end_pfn,
> + largepage_lvl + 1);
> + for_each_domain_iommu(i, domain)
> + iommu_flush_iotlb_psi(g_iommus[i], domain,
> + iov_pfn, nr_pages, 0, 0);
> +
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-04-02 4:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 7:18 [PATCH] iommu/vt-d: Force to flush iotlb before creating superpage Longpeng(Mike)
2021-04-02 3:06 ` Lu Baolu
2021-04-02 3:41 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-04-02 4:47 ` Lu Baolu
2021-04-02 4:44 ` Lu Baolu [this message]
2021-04-07 6:35 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-04-08 4:32 ` Lu Baolu
2021-04-08 7:37 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-04-09 5:31 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c368419-6e45-6b27-0f34-26b581589fa7@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).