From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF38EC18E5B for ; Wed, 1 Apr 2020 12:52:09 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F86420675 for ; Wed, 1 Apr 2020 12:52:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F86420675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5781986214; Wed, 1 Apr 2020 12:52:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gEv+JTyXrIOz; Wed, 1 Apr 2020 12:52:07 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 3D9698620B; Wed, 1 Apr 2020 12:52:07 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 371A5C1AE2; Wed, 1 Apr 2020 12:52:07 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 842FEC089F for ; Wed, 1 Apr 2020 12:52:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 733AD85D30 for ; Wed, 1 Apr 2020 12:52:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FgUlzbpAyxUP for ; Wed, 1 Apr 2020 12:52:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 3F9B685D11 for ; Wed, 1 Apr 2020 12:52:05 +0000 (UTC) IronPort-SDR: xtLgF7q/AN88/Xrd4kghPiBjc+Hswd2wBXNwJ0LeGfM67llOgHuXNw7QXSVFi4Jx4eADLjQ4Cl 3We94MMZxZpw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2020 05:52:04 -0700 IronPort-SDR: mARSEAqYVJ6C6D6b35OEX3tlAKOtDWH3rdn0XTNobRLr1MupdzSy7Ipt8iOv4A8rs6pJN1Xo26 c6oQZydb8TkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,331,1580803200"; d="scan'208";a="395967696" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 01 Apr 2020 05:52:03 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Apr 2020 05:52:03 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Apr 2020 05:52:03 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.7]) with mapi id 14.03.0439.000; Wed, 1 Apr 2020 20:51:59 +0800 From: "Liu, Yi L" To: Auger Eric , "alex.williamson@redhat.com" Subject: RE: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to userspace Thread-Topic: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to userspace Thread-Index: AQHWAEUcqZEEdiOKbEGofjWp2Yic+6hjfq+AgAC/vLA= Date: Wed, 1 Apr 2020 12:51:58 +0000 Message-ID: References: <1584880325-10561-1-git-send-email-yi.l.liu@intel.com> <1584880325-10561-6-git-send-email-yi.l.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Cc: "jean-philippe@linaro.org" , "Tian, Kevin" , "Raj, Ashok" , "kvm@vger.kernel.org" , "Tian, Jun J" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "Sun, Yi Y" , "Wu, Hao" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Eric, > From: Auger Eric > Sent: Wednesday, April 1, 2020 4:51 PM > To: Liu, Yi L ; alex.williamson@redhat.com > Subject: Re: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to > userspace > > Hi Yi, > On 3/22/20 1:32 PM, Liu, Yi L wrote: > > From: Liu Yi L > > > > VFIO exposes IOMMU nesting translation (a.k.a dual stage translation) > > capability to userspace. Thus applications like QEMU could support > > vIOMMU with hardware's nesting translation capability for pass-through > > devices. Before setting up nesting translation for pass-through devices, > > QEMU and other applications need to learn the supported 1st-lvl/stage-1 > > translation structure format like page table format. > > > > Take vSVA (virtual Shared Virtual Addressing) as an example, to support > > vSVA for pass-through devices, QEMU setup nesting translation for pass- > > through devices. The guest page table are configured to host as 1st-lvl/ > > stage-1 page table. Therefore, guest format should be compatible with > > host side. > > > > This patch reports the supported 1st-lvl/stage-1 page table format on the > > current platform to userspace. QEMU and other alike applications should > > use this format info when trying to setup IOMMU nesting translation on > > host IOMMU. > > > > Cc: Kevin Tian > > CC: Jacob Pan > > Cc: Alex Williamson > > Cc: Eric Auger > > Cc: Jean-Philippe Brucker > > Signed-off-by: Liu Yi L > > --- > > drivers/vfio/vfio_iommu_type1.c | 56 > +++++++++++++++++++++++++++++++++++++++++ > > include/uapi/linux/vfio.h | 1 + > > 2 files changed, 57 insertions(+) > > > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > > index 9aa2a67..82a9e0b 100644 > > --- a/drivers/vfio/vfio_iommu_type1.c > > +++ b/drivers/vfio/vfio_iommu_type1.c > > @@ -2234,11 +2234,66 @@ static int vfio_iommu_type1_pasid_free(struct > vfio_iommu *iommu, > > return ret; > > } > > > > +static int vfio_iommu_get_stage1_format(struct vfio_iommu *iommu, > > + u32 *stage1_format) > vfio_pasid_format() to be homogeneous with vfio_pgsize_bitmap() which > does the same kind of enumeration of the vfio_iommu domains yes, similar. > > +{ > > + struct vfio_domain *domain; > > + u32 format = 0, tmp_format = 0; > > + int ret; > ret = -EINVAL; got it. > > + > > + mutex_lock(&iommu->lock); > > + if (list_empty(&iommu->domain_list)) { > goto out_unlock; right. > > + mutex_unlock(&iommu->lock); > > + return -EINVAL; > > + } > > + > > + list_for_each_entry(domain, &iommu->domain_list, next) { > > + if (iommu_domain_get_attr(domain->domain, > > + DOMAIN_ATTR_PASID_FORMAT, &format)) { > I can find DOMAIN_ATTR_PASID_FORMAT in Jacob's v9 but not in v10 oops, I guess he somehow missed. you may find it in below link. https://github.com/luxis1999/linux-vsva/commit/bf14b11a12f74d58ad3ee626a5d891de395082eb > > + ret = -EINVAL; > could be removed sure. > > + format = 0; > > + goto out_unlock; > > + } > > + /* > > + * format is always non-zero (the first format is > > + * IOMMU_PASID_FORMAT_INTEL_VTD which is 1). For > > + * the reason of potential different backed IOMMU > > + * formats, here we expect to have identical formats > > + * in the domain list, no mixed formats support. > > + * return -EINVAL to fail the attempt of setup > > + * VFIO_TYPE1_NESTING_IOMMU if non-identical formats > > + * are detected. > > + */ > > + if (tmp_format && tmp_format != format) { > > + ret = -EINVAL; > could be removed got it. > > + format = 0; > > + goto out_unlock; > > + } > > + > > + tmp_format = format; > > + } > > + ret = 0; > > + > > +out_unlock: > > + if (format) > if (!ret) ? then you can remove the format = 0 in case of error. oh, yes. > > + *stage1_format = format; > > + mutex_unlock(&iommu->lock); > > + return ret; > > +} > > + > > static int vfio_iommu_info_add_nesting_cap(struct vfio_iommu *iommu, > > struct vfio_info_cap *caps) > > { > > struct vfio_info_cap_header *header; > > struct vfio_iommu_type1_info_cap_nesting *nesting_cap; > > + u32 formats = 0; > > + int ret; > > + > > + ret = vfio_iommu_get_stage1_format(iommu, &formats); > > + if (ret) { > > + pr_warn("Failed to get stage-1 format\n"); > trace triggered by userspace to be removed? sure. > > + return ret; > > + } > > > > header = vfio_info_cap_add(caps, sizeof(*nesting_cap), > > VFIO_IOMMU_TYPE1_INFO_CAP_NESTING, 1); > > @@ -2254,6 +2309,7 @@ static int vfio_iommu_info_add_nesting_cap(struct > vfio_iommu *iommu, > > /* nesting iommu type supports PASID requests (alloc/free) */ > > nesting_cap->nesting_capabilities |= VFIO_IOMMU_PASID_REQS; > What is the meaning for ARM? I think it's just a software capability exposed to userspace, on userspace side, it has a choice to use it or not. :-) The reason define it and report it in cap nesting is that I'd like to make the pasid alloc/free be available just for IOMMU with type VFIO_IOMMU_TYPE1_NESTING. Please feel free tell me if it is not good for ARM. We can find a proper way to report the availability. > > } > > + nesting_cap->stage1_formats = formats; > as spotted by Kevin, since a single format is supported, rename ok, I was believing it may be possible on ARM or so. :-) will rename it. I'll refine the patch per your above comments. Regards, Yi Liu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu