From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69316C43331 for ; Fri, 3 Apr 2020 11:59:49 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41B5B20737 for ; Fri, 3 Apr 2020 11:59:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41B5B20737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3164F87156; Fri, 3 Apr 2020 11:59:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0od-SDFG9Rwr; Fri, 3 Apr 2020 11:59:46 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 75EBE86BC2; Fri, 3 Apr 2020 11:59:46 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5931FC1831; Fri, 3 Apr 2020 11:59:46 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id EEEEFC07FF for ; Fri, 3 Apr 2020 11:59:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D8389876AE for ; Fri, 3 Apr 2020 11:59:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CZyXMFRy6ZtW for ; Fri, 3 Apr 2020 11:59:44 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by whitealder.osuosl.org (Postfix) with ESMTPS id F2C8486497 for ; Fri, 3 Apr 2020 11:59:43 +0000 (UTC) IronPort-SDR: mjbe7gDtDwTO4+15/l2hUaGK+3Ei5DHCpkbcg9GIV9FL3N6DY/C+W5xThbfls4/5bw9Dd0tYwQ skLNUxaNmP0w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2020 04:59:43 -0700 IronPort-SDR: o0hGTbs6M+FhSoPaDbBwvuj5xDfC7yiqYPV98EFZNRQHKrmKTy76BbUYXjXkcxQIQ662A1DZrU AlPE0PWz0NdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,339,1580803200"; d="scan'208";a="268339664" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 03 Apr 2020 04:59:42 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Apr 2020 04:59:37 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Apr 2020 04:59:37 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.22]) with mapi id 14.03.0439.000; Fri, 3 Apr 2020 19:59:33 +0800 From: "Liu, Yi L" To: Alex Williamson Subject: RE: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to userspace Thread-Topic: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to userspace Thread-Index: AQHWAEUcqZEEdiOKbEGofjWp2Yic+6hlwM8AgAGcrLA= Date: Fri, 3 Apr 2020 11:59:33 +0000 Message-ID: References: <1584880325-10561-1-git-send-email-yi.l.liu@intel.com> <1584880325-10561-6-git-send-email-yi.l.liu@intel.com> <20200402132012.390a7b54@w520.home> In-Reply-To: <20200402132012.390a7b54@w520.home> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Cc: "jean-philippe@linaro.org" , "Tian, Kevin" , "Raj, Ashok" , "kvm@vger.kernel.org" , "Tian, Jun J" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "Sun, Yi Y" , "Wu, Hao" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Alex, > From: Alex Williamson > Sent: Friday, April 3, 2020 3:20 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to > userspace > > On Sun, 22 Mar 2020 05:32:02 -0700 > "Liu, Yi L" wrote: > > > From: Liu Yi L > > > > VFIO exposes IOMMU nesting translation (a.k.a dual stage translation) > > capability to userspace. Thus applications like QEMU could support > > vIOMMU with hardware's nesting translation capability for pass-through > > devices. Before setting up nesting translation for pass-through devices, > > QEMU and other applications need to learn the supported 1st-lvl/stage-1 > > translation structure format like page table format. > > > > Take vSVA (virtual Shared Virtual Addressing) as an example, to support > > vSVA for pass-through devices, QEMU setup nesting translation for pass- > > through devices. The guest page table are configured to host as 1st-lvl/ > > stage-1 page table. Therefore, guest format should be compatible with > > host side. > > > > This patch reports the supported 1st-lvl/stage-1 page table format on the > > current platform to userspace. QEMU and other alike applications should > > use this format info when trying to setup IOMMU nesting translation on > > host IOMMU. > > > > Cc: Kevin Tian > > CC: Jacob Pan > > Cc: Alex Williamson > > Cc: Eric Auger > > Cc: Jean-Philippe Brucker > > Signed-off-by: Liu Yi L > > --- > > drivers/vfio/vfio_iommu_type1.c | 56 > +++++++++++++++++++++++++++++++++++++++++ > > include/uapi/linux/vfio.h | 1 + > > 2 files changed, 57 insertions(+) > > > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > > index 9aa2a67..82a9e0b 100644 > > --- a/drivers/vfio/vfio_iommu_type1.c > > +++ b/drivers/vfio/vfio_iommu_type1.c > > @@ -2234,11 +2234,66 @@ static int vfio_iommu_type1_pasid_free(struct > vfio_iommu *iommu, > > return ret; > > } > > > > +static int vfio_iommu_get_stage1_format(struct vfio_iommu *iommu, > > + u32 *stage1_format) > > +{ > > + struct vfio_domain *domain; > > + u32 format = 0, tmp_format = 0; > > + int ret; > > + > > + mutex_lock(&iommu->lock); > > + if (list_empty(&iommu->domain_list)) { > > + mutex_unlock(&iommu->lock); > > + return -EINVAL; > > + } > > + > > + list_for_each_entry(domain, &iommu->domain_list, next) { > > + if (iommu_domain_get_attr(domain->domain, > > + DOMAIN_ATTR_PASID_FORMAT, &format)) { > > + ret = -EINVAL; > > + format = 0; > > + goto out_unlock; > > + } > > + /* > > + * format is always non-zero (the first format is > > + * IOMMU_PASID_FORMAT_INTEL_VTD which is 1). For > > + * the reason of potential different backed IOMMU > > + * formats, here we expect to have identical formats > > + * in the domain list, no mixed formats support. > > + * return -EINVAL to fail the attempt of setup > > + * VFIO_TYPE1_NESTING_IOMMU if non-identical formats > > + * are detected. > > + */ > > + if (tmp_format && tmp_format != format) { > > + ret = -EINVAL; > > + format = 0; > > + goto out_unlock; > > + } > > + > > + tmp_format = format; > > + } > > + ret = 0; > > + > > +out_unlock: > > + if (format) > > + *stage1_format = format; > > + mutex_unlock(&iommu->lock); > > + return ret; > > +} > > + > > static int vfio_iommu_info_add_nesting_cap(struct vfio_iommu *iommu, > > struct vfio_info_cap *caps) > > { > > struct vfio_info_cap_header *header; > > struct vfio_iommu_type1_info_cap_nesting *nesting_cap; > > + u32 formats = 0; > > + int ret; > > + > > + ret = vfio_iommu_get_stage1_format(iommu, &formats); > > + if (ret) { > > + pr_warn("Failed to get stage-1 format\n"); > > + return ret; > > Looks like this generates a warning and causes the iommu_get_info ioctl > to fail if the hardware doesn't support the pasid format attribute, or > the domain list is empty. This breaks users on existing hardware. oops, yes, it should not fail anything as it is just an extended feature. let me correct it. Thanks, Yi Liu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu