From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=FORGED_MUA_MOZILLA, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 667F1C433E0 for ; Thu, 25 Jun 2020 08:06:06 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 302E320720 for ; Thu, 25 Jun 2020 08:06:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 302E320720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=live.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 079E387677; Thu, 25 Jun 2020 08:06:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Vr3f5GMTRNf; Thu, 25 Jun 2020 08:06:05 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 5B0FA8613C; Thu, 25 Jun 2020 08:06:05 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4B753C0863; Thu, 25 Jun 2020 08:06:05 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id DE9D7C016F for ; Wed, 24 Jun 2020 21:47:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D23DA20020 for ; Wed, 24 Jun 2020 21:47:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gJ5PfBIRhNxL for ; Wed, 24 Jun 2020 21:47:26 +0000 (UTC) X-Greylist: delayed 00:18:54 by SQLgrey-1.7.6 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2074.outbound.protection.outlook.com [40.92.41.74]) by silver.osuosl.org (Postfix) with ESMTPS id 6765E1FEED for ; Wed, 24 Jun 2020 21:47:26 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WIxRBAycnrwj82FPmojwpgcyYfUtikpJhJ7ReMu+4guQn6jGk68/wALJFkHwklg6ZyEPjPOhCPxstlR98jnvWI503XNv2XiOxIDvafFLeCLhKlTG6JjOQcKYZY/Sc0WJpfnbhtb1gWHGIkBr2WC/jvOs2j1nb7p7BX4zMSic0WwAJWCwM8V/CN/7WMIIUO/UCaxEkVEjTBj/voTLB1LcMzV4YcQd7s204o29R/4CLxhS1SC1sKOP6aNht3fO5x1RXpGzlNVGzR9rPxgyeGN4CQK5YLsMzoAlRkuCulRWfdA0y4le0ZX7EJmCKtfBAge5cZuo5UFKmS2sJr8a+GvVHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8CrmGzPXzKI3jNbwSiL6uV8Tmje9ePu/xLdQI4zVnhw=; b=NSFsmqP011XsaH/QMsZIAsb6jPGsq/CQdFZFa7ch9pvEgHxTcBCsgr1zOXGxBdU2DxoAeoiq7oBnegWA1HknD/0f+ACV1fbAz/GmK8KtARmzgKmDgNp6P3c+JtEuBkHINaO+Glm0a9sJjxfK/NufsKZp78K+dYd3lWCYTHXJbcb4oNCWyYc0Q1BjVHyOL4iClkVfK/4KQkCjaiFNZ0ZHJpxhDX+MnGqzAkLRsFG5U+1rrDchSNpWqjKxmfe3JpLnTQLdhyxrU9OnUeA1vW4+vvTlALaro17Sr9EthuxurKTnDrz+BmVQeTfVQ93A/yVMCNIVWdrH5Lf+kFTXdpeEuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BN7NAM10FT054.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::48) by BN7NAM10HT119.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::463) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20; Wed, 24 Jun 2020 21:14:19 +0000 Received: from BN6PR04MB0660.namprd04.prod.outlook.com (2a01:111:e400:7e8f::41) by BN7NAM10FT054.mail.protection.outlook.com (2a01:111:e400:7e8f::368) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Wed, 24 Jun 2020 21:14:19 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:8EAA0BA33DA596B0431D042A55E8E8F04DF3B3F9D273D3C0ADC17017CC8DE5B4; UpperCasedChecksum:1952420B62F245174FCDFD5DAAD7CC84C2AB14B2F50614CBD8980AFFFD81799B; SizeAsReceived:9609; Count:49 Received: from BN6PR04MB0660.namprd04.prod.outlook.com ([fe80::b9c3:9bff:541d:f383]) by BN6PR04MB0660.namprd04.prod.outlook.com ([fe80::b9c3:9bff:541d:f383%9]) with mapi id 15.20.3109.027; Wed, 24 Jun 2020 21:14:19 +0000 Subject: Re: [PATCH 00/11] media: exynos4-is: Improve support for s5pv210 and parallel ports To: Tomasz Figa , Krzysztof Kozlowski References: <07fb9000-ae00-efcd-e91a-48765ff3d4bf@xs4all.nl> <20200624115419.GA20764@pi3> From: Jonathan Bakker Message-ID: Date: Wed, 24 Jun 2020 14:14:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 In-Reply-To: Content-Language: en-US X-ClientProxiedBy: MWHPR07CA0005.namprd07.prod.outlook.com (2603:10b6:300:116::15) To BN6PR04MB0660.namprd04.prod.outlook.com (2603:10b6:404:d9::21) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:569:fb68:9c00:8067:f823:1e15:7520] (2001:569:fb68:9c00:8067:f823:1e15:7520) by MWHPR07CA0005.namprd07.prod.outlook.com (2603:10b6:300:116::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Wed, 24 Jun 2020 21:14:17 +0000 X-Microsoft-Original-Message-ID: X-TMN: [paftjWaebweO0jKyE2GK8Uv0cYFzShmKvoelg+gAQYGksWntRJ65SdnMpnLZQEx8] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: e0f0716d-a91a-4249-458e-08d818838eea X-MS-TrafficTypeDiagnostic: BN7NAM10HT119: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HwXtJghjvTuAM9uJyjCbfjKIFVaLDGnuAmfc2c148lxHdF1BEjNMuXKzstJfRU9Z7bfn8lQeyXraxadsqI36EbBNCtQfTjVzI6jNv+nOOhXVdR9PKmcLUSYnV3vRpEhe4wRgRFatRtakRcIwWj7vPnZEyFz4vRN/e7IL5qttzvsp0UOXQui4dzAROxdNVCsZRz3niYiLqLglIZEUgtu3Jg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR04MB0660.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: 0LJhqkaMT4495vkSwNW8yuKx9A3HyALkJd8G8p8uyiFPYSO29zZNu9v6vYZy36adYP8WaZP2KVFA1zMRzwSjO1uWzRvfUM4SWiZlVknhp1lnhtX3+8jJuBO+su+myVa9SzG6lFAoYTyzgj6WzVvnSqmevfrRZ+tOS8vfXPCYGIOsTfOxIt1P9KVENNMk60dLoEOwcvJ8E1wp1F93fUN8qg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0f0716d-a91a-4249-458e-08d818838eea X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2020 21:14:19.3903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN7NAM10FT054.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT119 X-Mailman-Approved-At: Thu, 25 Jun 2020 08:06:03 +0000 Cc: linux-samsung-soc , "list@263.net:IOMMU DRIVERS" , Linux Kernel Mailing List , Hans Verkuil , Kyungmin Park , kgene@kernel.org, Sylwester Nawrocki , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Linux Media Mailing List X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Tomasz, On 2020-06-24 4:58 a.m., Tomasz Figa wrote: > On Wed, Jun 24, 2020 at 1:54 PM Krzysztof Kozlowski wrote: >> >> On Wed, Jun 24, 2020 at 01:39:50PM +0200, Hans Verkuil wrote: >>> Can someone from Samsung or someone who knows this SoC take a look at this series? >>> >>> This series looks sane to me, so I'll probably merge this if nobody replies >>> in the next two weeks or so. >> >> Unfortunately I don't know the media part on S5Pv210 at all so I cannot >> provide any feedback. There are not many active users of these SoCs >> nowadays. One of hem is Jonathan, so if he wants to change something he will >> mostly break/affect his own setup. :) Therefore I think it is safe to merge. > > I think this driver is also used on Exynos4210 and on some setups with > 4412 where the ISP is not used. Yes, this driver is also used by Exynos4210 and Exynos4412, notably by the Galaxy S3 series. They don't use the parallel ports, but rather the CSIS. I don't believe I've broken support for that, but I don't have the hardware to test. My other remaining concern is whether to adjust the camera port A/camera port B to match the device tree documentation or to update the documentation to match the driver. I decided to update the driver in these patches, but it is much simpler to simply update the binding doc. The only mainline user of the parallel ports is the Goni dev board which appears to be setup for the driver way of numbering as opposed to the binding doc. I have no strong preference on which way to actually go. > > I can't promise anything, but I'll try to do a high level review. > Hopefully I still have some memory from the time I used to play with > this hardware. Thanks, that would be appreciated, Jonathan > > Best regards, > Tomasz > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu