From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5137BC35257 for ; Mon, 21 Sep 2020 18:33:42 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C45FE22574 for ; Mon, 21 Sep 2020 18:33:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s/2lSfEC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C45FE22574 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3BC7A87184; Mon, 21 Sep 2020 18:33:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NGR5h4-6orcc; Mon, 21 Sep 2020 18:33:39 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id DDD13857E6; Mon, 21 Sep 2020 18:33:39 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C4B2EC0859; Mon, 21 Sep 2020 18:33:39 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2234AC0051 for ; Mon, 21 Sep 2020 18:33:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 1C58985F6D for ; Mon, 21 Sep 2020 18:33:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c34cD6JeVgnM for ; Mon, 21 Sep 2020 18:33:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by whitealder.osuosl.org (Postfix) with ESMTPS id 01A7A81439 for ; Mon, 21 Sep 2020 18:33:34 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id s13so458415wmh.4 for ; Mon, 21 Sep 2020 11:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2pljieOa3zqVRg/nGCsqWTPIMVj9a7ObD+5hzvK2Z0I=; b=s/2lSfECPbjLHM2LdhQLNaMh78qvA/Uu+BsbwbIwRyEVeTA30UJJJ26rlr0/UdPmIj q6EtpiecmC2cTci+sv0gqZhFfHO0H9VgrYQ/YF7xuti1+alXMRMily9jWUq/lvLQ9b9G SpcGH6rlbNgPOBVhfYQK1JE5JfKgj4cLpi2MYoRmZbY/f1VzAD55/ZBfiqWlqi+W8QK2 2fsbgcim3qo9fRXr77t63uZtuqi4MJmRs/vywjq3keI9xP9xz9HwvGNlGjs8XKZZFF33 /tOeYdh+UaFxmA6mb9Jb3PdX7yYd2lRr3gUz9pzyjPXpriHZQ2Hiw4klgPs/5bo/ObzN wspA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2pljieOa3zqVRg/nGCsqWTPIMVj9a7ObD+5hzvK2Z0I=; b=Pt5ygZLQ7etGDMDcui+y5OzWDltJ1V5CvuO1l2d3i7ujgn4fuTTYxfk1eiOZgyrjfO nUYi324h4MHqMmHdorPDXY+/XIGyj/DvyoY+yDPYozx/WgHQHnazADe560klWfHWaQja Xaubvpk1mAxPZNs1yjHVkgAp1xC+aBFOJe5jDZNSlpwhG82+g6CV6G1NbdMTu0h7AmDK XwRSrxLjQG89/8ZAqzloGdCgbhaW0H2w6n6CvBMlfqzt5hYVXdRTWNfiwI1Rp2Km7QHl 5RCLBXwojyaizc0xngqoLResJ6gI/MqQ91MpAySr1xwf+JsWnoCmbK1NFcV8yLP3P/lA 8Pag== X-Gm-Message-State: AOAM531yxeQKJSMhoL33FDXLWpVEh1fommrmzHETT7CYKv6eVAMmyDgQ r1z3Kr7rWa46T8QdebidCn+SgB9w97HAy4OfKAI= X-Google-Smtp-Source: ABdhPJwOdkyX2T0nNsDtEYqTQPWOnuWTEliEywfKgd/Kd/kkmsATU6V+QmG/OrZNm2joFQfWrCrOoKg8VsCqThpuZIU= X-Received: by 2002:a7b:c345:: with SMTP id l5mr630045wmj.123.1600713213466; Mon, 21 Sep 2020 11:33:33 -0700 (PDT) MIME-Version: 1.0 References: <20200918011357.909335-1-yukuai3@huawei.com> <20200921175048.GD3141@willie-the-truck> In-Reply-To: From: Rob Clark Date: Mon, 21 Sep 2020 11:33:21 -0700 Message-ID: Subject: Re: [PATCH] iommu/qcom: add missing put_device() call in qcom_iommu_of_xlate() To: Will Deacon Cc: yi.zhang@huawei.com, linux-arm-msm , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Yu Kuai , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Sep 21, 2020 at 11:27 AM Rob Clark wrote: > > On Mon, Sep 21, 2020 at 10:50 AM Will Deacon wrote: > > > > On Fri, Sep 18, 2020 at 09:13:57AM +0800, Yu Kuai wrote: > > > if of_find_device_by_node() succeed, qcom_iommu_of_xlate() doesn't have > > > a corresponding put_device(). Thus add put_device() to fix the exception > > > handling for this function implementation. > > > > > > Fixes: e86d1aa8b60f ("iommu/arm-smmu: Move Arm SMMU drivers into their own subdirectory") > > > > That's probably not accurate, in that this driver used to live under > > drivers/iommu/ and assumedly had this bug there as well. > > and fwiw, that looks like it should be: Fixes: 0ae349a0f33fb ("iommu/qcom: Add qcom_iommu") > > > Signed-off-by: Yu Kuai > > > --- > > > drivers/iommu/arm/arm-smmu/qcom_iommu.c | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > I guess Rob will pick this up. > > Probably overkill for me to send a pull req for a single patch, if you > want to pick it up: > > Acked-by: Rob Clark _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu