From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F94C43461 for ; Sat, 5 Sep 2020 18:31:59 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 909892074D for ; Sat, 5 Sep 2020 18:31:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k5ekDg/2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 909892074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1E19520781; Sat, 5 Sep 2020 18:31:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kq2M-lpRmkSb; Sat, 5 Sep 2020 18:31:54 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id E166F203E7; Sat, 5 Sep 2020 18:31:53 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B8C8AC0052; Sat, 5 Sep 2020 18:31:53 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 008D0C0051 for ; Sat, 5 Sep 2020 18:31:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id DCABF85F89 for ; Sat, 5 Sep 2020 18:31:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2PGn7MoF_4dC for ; Sat, 5 Sep 2020 18:31:50 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 8284E85F88 for ; Sat, 5 Sep 2020 18:31:50 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id t10so10664383wrv.1 for ; Sat, 05 Sep 2020 11:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v7rsoN6MaCp+62McHT2xPaACCltEz0sVvL0q+af3xvA=; b=k5ekDg/2n2KPHX6zcuDCtrPS5418RvP2WhZtaWC6IDqepiLCm+SNYs1uEo7WvzUGG8 esLRgyNlR/jvIR8SvBJ+xFFbfvBhHCvQjQsfHGjZb9RVzruSqaN3Hn9D9X3/ATTKo6jd 8JvgaIPEwHBJQYBDes8vrI5aXODM08MGcZ0Mwz1LuiaeDwcHdQrwnqk9Rr7Urn+eUUDV 86iNdAmzJkM6GXQdjF4MK8RVc4FsLl9xakfLJpJRUmx4TejKa2fPt9mol7aXZ1u7/0JS ORheXiuZecJLd042Vclh4JzlwcRB0x4BChMPvvCwEUp5XmXvGkljG7u1YkYnereC4qFZ V16A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v7rsoN6MaCp+62McHT2xPaACCltEz0sVvL0q+af3xvA=; b=s4x3mbwBXc6Y/k9y7kzQsK7VUVw65nXKj2SrfgVflSq8vxkTVraYmSY54sUfTqr/+6 vrKD8F3IWK8pwckKaxgiY954BjD3bdSqzcQvDGsXMEdYbxFZWreSEwyLlhX6+Dmwf8N5 iYiEZ2J785euGMn2+c/etsL7lXqgGKoDF+i0/VGsEX+4F2rcpLKqRmMDFbcRPnAsulEh qWRz9l54dqJcLx85+4+ZWwN38jSuQhLSDe7JfjFLfT3ht/PY0IdUJH+t2O4C9hTMyhHa tD6efabtweZ9St3Crz3FzvF8PwISx9VWQRGTuEIBTPoSL6PS59f0PXIHLLzwq/yl+0yt 8tHg== X-Gm-Message-State: AOAM530mzIojPTZKbZI83aMvV8xr0SwlDvH0O5nJctnW/F5zbThDfR0B ZZIUl/sL9P28o07cm6LbgwUbNhrz4ucPi2W3Abc= X-Google-Smtp-Source: ABdhPJx61KkZ3R+ATAyYdnW/HRL5V/1BNVF8qDCqyQ47aJ4r+2Swa0B1JJL+q5XBwgqg6IDZ/82PaF+zTXmudqRlDes= X-Received: by 2002:adf:f382:: with SMTP id m2mr12748791wro.327.1599330708634; Sat, 05 Sep 2020 11:31:48 -0700 (PDT) MIME-Version: 1.0 References: <20200901164707.2645413-1-robdclark@gmail.com> <20200901164707.2645413-15-robdclark@gmail.com> <20200904160018.GH3715@yoga> In-Reply-To: <20200904160018.GH3715@yoga> From: Rob Clark Date: Sat, 5 Sep 2020 11:32:43 -0700 Message-ID: Subject: Re: [PATCH v16 14/20] iommu/arm-smmu: Prepare for the adreno-smmu implementation To: Bjorn Andersson Cc: Rob Clark , open list , Jonathan Marek , linux-arm-msm , Robin Murphy , dri-devel , Stephen Boyd , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Akhil P Oommen , Sibi Sankar , Vivek Gautam , Greg Kroah-Hartman , Will Deacon , Hanna Hawa , "moderated list:ARM SMMU DRIVERS" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Sep 4, 2020 at 9:00 AM Bjorn Andersson wrote: > > On Tue 01 Sep 11:46 CDT 2020, Rob Clark wrote: > > > From: Jordan Crouse > > > > Do a bit of prep work to add the upcoming adreno-smmu implementation. > > > > Add an hook to allow the implementation to choose which context banks > > to allocate. > > > > Move some of the common structs to arm-smmu.h in anticipation of them > > being used by the implementations and update some of the existing hooks > > to pass more information that the implementation will need. > > > > These modifications will be used by the upcoming Adreno SMMU > > implementation to identify the GPU device and properly configure it > > for pagetable switching. > > > > Co-developed-by: Rob Clark > > Signed-off-by: Jordan Crouse > > Signed-off-by: Rob Clark > > As I built the handoff support on top of this patch I ended up > reworking the alloc_context_bank() prototype to something I found a > little bit cleaner. > > So perhaps you would be interested in squashing > https://lore.kernel.org/linux-arm-msm/20200904155513.282067-2-bjorn.andersson@linaro.org/ > into this patch? Yeah, I think this looks nicer, thanks BR, -R > Otherwise, feel free to add my: > > Reviewed-by: Bjorn Andersson > > Regards, > Bjorn > > > --- > > drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 2 +- > > drivers/iommu/arm/arm-smmu/arm-smmu.c | 69 ++++++---------------- > > drivers/iommu/arm/arm-smmu/arm-smmu.h | 51 +++++++++++++++- > > 3 files changed, 68 insertions(+), 54 deletions(-) > > > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c b/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c > > index a9861dcd0884..88f17cc33023 100644 > > --- a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c > > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c > > @@ -69,7 +69,7 @@ static int cavium_cfg_probe(struct arm_smmu_device *smmu) > > } > > > > static int cavium_init_context(struct arm_smmu_domain *smmu_domain, > > - struct io_pgtable_cfg *pgtbl_cfg) > > + struct io_pgtable_cfg *pgtbl_cfg, struct device *dev) > > { > > struct cavium_smmu *cs = container_of(smmu_domain->smmu, > > struct cavium_smmu, smmu); > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c > > index 8e884e58f208..68b7b9e6140e 100644 > > --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c > > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c > > @@ -65,41 +65,10 @@ module_param(disable_bypass, bool, S_IRUGO); > > MODULE_PARM_DESC(disable_bypass, > > "Disable bypass streams such that incoming transactions from devices that are not attached to an iommu domain will report an abort back to the device and will not be allowed to pass through the SMMU."); > > > > -struct arm_smmu_s2cr { > > - struct iommu_group *group; > > - int count; > > - enum arm_smmu_s2cr_type type; > > - enum arm_smmu_s2cr_privcfg privcfg; > > - u8 cbndx; > > -}; > > - > > #define s2cr_init_val (struct arm_smmu_s2cr){ \ > > .type = disable_bypass ? S2CR_TYPE_FAULT : S2CR_TYPE_BYPASS, \ > > } > > > > -struct arm_smmu_smr { > > - u16 mask; > > - u16 id; > > - bool valid; > > -}; > > - > > -struct arm_smmu_cb { > > - u64 ttbr[2]; > > - u32 tcr[2]; > > - u32 mair[2]; > > - struct arm_smmu_cfg *cfg; > > -}; > > - > > -struct arm_smmu_master_cfg { > > - struct arm_smmu_device *smmu; > > - s16 smendx[]; > > -}; > > -#define INVALID_SMENDX -1 > > -#define cfg_smendx(cfg, fw, i) \ > > - (i >= fw->num_ids ? INVALID_SMENDX : cfg->smendx[i]) > > -#define for_each_cfg_sme(cfg, fw, i, idx) \ > > - for (i = 0; idx = cfg_smendx(cfg, fw, i), i < fw->num_ids; ++i) > > - > > static bool using_legacy_binding, using_generic_binding; > > > > static inline int arm_smmu_rpm_get(struct arm_smmu_device *smmu) > > @@ -234,19 +203,6 @@ static int arm_smmu_register_legacy_master(struct device *dev, > > } > > #endif /* CONFIG_ARM_SMMU_LEGACY_DT_BINDINGS */ > > > > -static int __arm_smmu_alloc_bitmap(unsigned long *map, int start, int end) > > -{ > > - int idx; > > - > > - do { > > - idx = find_next_zero_bit(map, end, start); > > - if (idx == end) > > - return -ENOSPC; > > - } while (test_and_set_bit(idx, map)); > > - > > - return idx; > > -} > > - > > static void __arm_smmu_free_bitmap(unsigned long *map, int idx) > > { > > clear_bit(idx, map); > > @@ -578,7 +534,7 @@ static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain, > > } > > } > > > > -static void arm_smmu_write_context_bank(struct arm_smmu_device *smmu, int idx) > > +void arm_smmu_write_context_bank(struct arm_smmu_device *smmu, int idx) > > { > > u32 reg; > > bool stage1; > > @@ -665,7 +621,8 @@ static void arm_smmu_write_context_bank(struct arm_smmu_device *smmu, int idx) > > } > > > > static int arm_smmu_init_domain_context(struct iommu_domain *domain, > > - struct arm_smmu_device *smmu) > > + struct arm_smmu_device *smmu, > > + struct device *dev) > > { > > int irq, start, ret = 0; > > unsigned long ias, oas; > > @@ -780,10 +737,20 @@ static int arm_smmu_init_domain_context(struct iommu_domain *domain, > > ret = -EINVAL; > > goto out_unlock; > > } > > - ret = __arm_smmu_alloc_bitmap(smmu->context_map, start, > > + > > + smmu_domain->smmu = smmu; > > + > > + if (smmu->impl && smmu->impl->alloc_context_bank) > > + ret = smmu->impl->alloc_context_bank(smmu_domain, dev, > > + start, smmu->num_context_banks); > > + else > > + ret = __arm_smmu_alloc_bitmap(smmu->context_map, start, > > smmu->num_context_banks); > > - if (ret < 0) > > + > > + if (ret < 0) { > > + smmu_domain->smmu = NULL; > > goto out_unlock; > > + } > > > > cfg->cbndx = ret; > > if (smmu->version < ARM_SMMU_V2) { > > @@ -798,8 +765,6 @@ static int arm_smmu_init_domain_context(struct iommu_domain *domain, > > else > > cfg->asid = cfg->cbndx; > > > > - smmu_domain->smmu = smmu; > > - > > pgtbl_cfg = (struct io_pgtable_cfg) { > > .pgsize_bitmap = smmu->pgsize_bitmap, > > .ias = ias, > > @@ -810,7 +775,7 @@ static int arm_smmu_init_domain_context(struct iommu_domain *domain, > > }; > > > > if (smmu->impl && smmu->impl->init_context) { > > - ret = smmu->impl->init_context(smmu_domain, &pgtbl_cfg); > > + ret = smmu->impl->init_context(smmu_domain, &pgtbl_cfg, dev); > > if (ret) > > goto out_clear_smmu; > > } > > @@ -1194,7 +1159,7 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > > return ret; > > > > /* Ensure that the domain is finalised */ > > - ret = arm_smmu_init_domain_context(domain, smmu); > > + ret = arm_smmu_init_domain_context(domain, smmu, dev); > > if (ret < 0) > > goto rpm_put; > > > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.h b/drivers/iommu/arm/arm-smmu/arm-smmu.h > > index f3e456893f28..59ff3fc5c6c8 100644 > > --- a/drivers/iommu/arm/arm-smmu/arm-smmu.h > > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.h > > @@ -256,6 +256,21 @@ enum arm_smmu_implementation { > > QCOM_SMMUV2, > > }; > > > > +struct arm_smmu_s2cr { > > + struct iommu_group *group; > > + int count; > > + enum arm_smmu_s2cr_type type; > > + enum arm_smmu_s2cr_privcfg privcfg; > > + u8 cbndx; > > +}; > > + > > +struct arm_smmu_smr { > > + u16 mask; > > + u16 id; > > + bool valid; > > + bool pinned; > > +}; > > + > > struct arm_smmu_device { > > struct device *dev; > > > > @@ -331,6 +346,13 @@ struct arm_smmu_cfg { > > }; > > #define ARM_SMMU_INVALID_IRPTNDX 0xff > > > > +struct arm_smmu_cb { > > + u64 ttbr[2]; > > + u32 tcr[2]; > > + u32 mair[2]; > > + struct arm_smmu_cfg *cfg; > > +}; > > + > > enum arm_smmu_domain_stage { > > ARM_SMMU_DOMAIN_S1 = 0, > > ARM_SMMU_DOMAIN_S2, > > @@ -350,6 +372,11 @@ struct arm_smmu_domain { > > struct iommu_domain domain; > > }; > > > > +struct arm_smmu_master_cfg { > > + struct arm_smmu_device *smmu; > > + s16 smendx[]; > > +}; > > + > > static inline u32 arm_smmu_lpae_tcr(struct io_pgtable_cfg *cfg) > > { > > u32 tcr = FIELD_PREP(ARM_SMMU_TCR_TG0, cfg->arm_lpae_s1_cfg.tcr.tg) | > > @@ -400,14 +427,35 @@ struct arm_smmu_impl { > > int (*cfg_probe)(struct arm_smmu_device *smmu); > > int (*reset)(struct arm_smmu_device *smmu); > > int (*init_context)(struct arm_smmu_domain *smmu_domain, > > - struct io_pgtable_cfg *cfg); > > + struct io_pgtable_cfg *cfg, struct device *dev); > > void (*tlb_sync)(struct arm_smmu_device *smmu, int page, int sync, > > int status); > > int (*def_domain_type)(struct device *dev); > > irqreturn_t (*global_fault)(int irq, void *dev); > > irqreturn_t (*context_fault)(int irq, void *dev); > > + int (*alloc_context_bank)(struct arm_smmu_domain *smmu_domain, > > + struct device *dev, int start, int max); > > }; > > > > +#define INVALID_SMENDX -1 > > +#define cfg_smendx(cfg, fw, i) \ > > + (i >= fw->num_ids ? INVALID_SMENDX : cfg->smendx[i]) > > +#define for_each_cfg_sme(cfg, fw, i, idx) \ > > + for (i = 0; idx = cfg_smendx(cfg, fw, i), i < fw->num_ids; ++i) > > + > > +static inline int __arm_smmu_alloc_bitmap(unsigned long *map, int start, int end) > > +{ > > + int idx; > > + > > + do { > > + idx = find_next_zero_bit(map, end, start); > > + if (idx == end) > > + return -ENOSPC; > > + } while (test_and_set_bit(idx, map)); > > + > > + return idx; > > +} > > + > > static inline void __iomem *arm_smmu_page(struct arm_smmu_device *smmu, int n) > > { > > return smmu->base + (n << smmu->pgshift); > > @@ -472,6 +520,7 @@ struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device *smmu); > > struct arm_smmu_device *nvidia_smmu_impl_init(struct arm_smmu_device *smmu); > > struct arm_smmu_device *qcom_smmu_impl_init(struct arm_smmu_device *smmu); > > > > +void arm_smmu_write_context_bank(struct arm_smmu_device *smmu, int idx); > > int arm_mmu500_reset(struct arm_smmu_device *smmu); > > > > #endif /* _ARM_SMMU_H */ > > -- > > 2.26.2 > > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu