iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Qian Cai <cai@lca.pw>
Cc: iommu <iommu@lists.linux-foundation.org>,
	Joerg Roedel <jroedel@suse.de>, Christoph Hellwig <hch@lst.de>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iommu/amd: fix a crash in iova_magazine_free_pfns
Date: Sun, 21 Jul 2019 09:58:04 -0700	[thread overview]
Message-ID: <CAHk-=wgwd9vT1h7jKMU_E4ae2QLFFH69UxcXpO3J9YqEApdUNg@mail.gmail.com> (raw)
In-Reply-To: <1562861865-23660-1-git-send-email-cai@lca.pw>

On Thu, Jul 11, 2019 at 9:18 AM Qian Cai <cai@lca.pw> wrote:
>
> The commit b3aa14f02254 ("iommu: remove the mapping_error dma_map_ops
> method") incorrectly changed the checking from dma_ops_alloc_iova() in
> map_sg() causes a crash under memory pressure as dma_ops_alloc_iova()
> never return DMA_MAPPING_ERROR on failure but 0, so the error handling
> is all wrong.

This one seems to have fallen through the cracks.

Applied directly.

Maybe it's hiding in some fixes tree that I haven't gotten a pull
request for yet?

           Linus
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  parent reply	other threads:[~2019-07-21 16:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 16:17 [PATCH v2] iommu/amd: fix a crash in iova_magazine_free_pfns Qian Cai
2019-07-11 16:21 ` Christoph Hellwig
2019-07-21 16:58 ` Linus Torvalds [this message]
2019-07-22 13:30   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgwd9vT1h7jKMU_E4ae2QLFFH69UxcXpO3J9YqEApdUNg@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=cai@lca.pw \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).