iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	iommu@lists.linux-foundation.org, jonathanh@nvidia.com,
	thierry.reding@gmail.com, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 1/3] memory: tegra: Add devm_tegra_get_memory_controller()
Date: Wed, 30 Sep 2020 16:45:13 +0200	[thread overview]
Message-ID: <CAJKOXPfbCRDY7TUZ4HXphrd6boWYEKb_DMOxth3ucPTB2UCUtw@mail.gmail.com> (raw)
In-Reply-To: <f9712d4c-8497-ca84-0d8a-d33eb6abc513@gmail.com>

On Wed, 30 Sep 2020 at 16:41, Dmitry Osipenko <digetx@gmail.com> wrote:
>
> ...
> > +struct tegra_mc *devm_tegra_get_memory_controller(struct device *dev)
> > +{
> > +     struct platform_device *pdev;
> > +     struct device_node *np;
> > +     struct tegra_mc *mc;
> > +     int err;
> > +
> > +     np = of_find_matching_node_and_match(NULL, tegra_mc_of_match, NULL);
> > +     if (!np)
> > +             return ERR_PTR(-ENOENT);
> > +
> > +     pdev = of_find_device_by_node(np);
> > +     of_node_put(np);
> > +     if (!pdev)
> > +             return ERR_PTR(-ENODEV);
> > +
> > +     mc = platform_get_drvdata(pdev);
> > +     if (!mc) {
> > +             put_device(mc->dev);
>
> This should be put_device(&pdev->dev). Please always be careful while
> copying someones else code :)

Good catch. I guess devm_add_action_or_reset() would also work... or
running Smatch on new code. Smatch should point it out.

Best regards,
Krzysztof
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2020-09-30 14:45 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  8:42 [PATCH v3 0/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-09-30  8:42 ` [PATCH v3 1/3] memory: tegra: Add devm_tegra_get_memory_controller() Nicolin Chen
2020-09-30  9:07   ` Krzysztof Kozlowski
2020-09-30  9:41     ` Nicolin Chen
2020-09-30 10:27       ` Krzysztof Kozlowski
2020-09-30 14:41   ` Dmitry Osipenko
2020-09-30 14:45     ` Krzysztof Kozlowski [this message]
2020-09-30 15:22       ` Dmitry Osipenko
2020-09-30 15:23   ` Thierry Reding
2020-09-30 15:27     ` Dmitry Osipenko
2020-09-30 15:53     ` Dmitry Osipenko
2020-09-30 16:03       ` Thierry Reding
2020-09-30 16:06         ` Dmitry Osipenko
2020-09-30 16:15           ` Thierry Reding
2020-09-30 16:26             ` Dmitry Osipenko
2020-09-30 16:38               ` Thierry Reding
2020-09-30 17:32                 ` Dmitry Osipenko
2020-09-30  8:42 ` [PATCH v3 2/3] iommu/tegra-smmu: Rework .probe_device and .attach_dev Nicolin Chen
2020-09-30  9:21   ` Krzysztof Kozlowski
2020-09-30  9:40     ` Nicolin Chen
2020-09-30 10:19       ` Krzysztof Kozlowski
2020-09-30 14:41   ` Dmitry Osipenko
2020-09-30 15:09   ` Dmitry Osipenko
2020-09-30 20:51     ` Nicolin Chen
2020-09-30 15:31   ` Thierry Reding
2020-09-30 15:36     ` Dmitry Osipenko
2020-09-30 16:06       ` Thierry Reding
2020-09-30 16:25         ` Dmitry Osipenko
2020-09-30 16:47           ` Thierry Reding
2020-10-01  2:11             ` Dmitry Osipenko
2020-10-01  7:58               ` Thierry Reding
2020-10-01 19:04                 ` Dmitry Osipenko
2020-10-05  9:16                   ` Thierry Reding
2020-10-05  9:38                     ` Dmitry Osipenko
2020-10-05 10:27                       ` Thierry Reding
2020-09-30 16:10       ` Thierry Reding
2020-09-30 16:29         ` Dmitry Osipenko
2020-10-01  7:59           ` Thierry Reding
2020-09-30 20:36     ` Nicolin Chen
2020-09-30 21:24       ` Dmitry Osipenko
2020-09-30 21:32         ` Nicolin Chen
2020-09-30 21:56           ` Dmitry Osipenko
2020-10-01  1:26             ` Nicolin Chen
2020-10-01  2:06               ` Dmitry Osipenko
2020-10-01  2:48                 ` Nicolin Chen
2020-10-01  4:04                   ` Dmitry Osipenko
2020-10-01 10:23                   ` Thierry Reding
2020-10-01 11:04                     ` Nicolin Chen
2020-10-01 20:33                       ` Dmitry Osipenko
2020-10-02  1:07                         ` Nicolin Chen
2020-10-02  1:55                           ` Dmitry Osipenko
2020-10-02  2:54                             ` Nicolin Chen
2020-10-05  7:24                             ` Thierry Reding
2020-10-05  7:13                         ` Thierry Reding
2020-10-05  8:14                           ` Dmitry Osipenko
2020-10-05  9:31                             ` Thierry Reding
2020-10-01  9:54                 ` Thierry Reding
2020-10-01  9:51               ` Thierry Reding
2020-10-01 10:33                 ` Nicolin Chen
2020-10-01 10:42                   ` Thierry Reding
2020-10-01  9:47       ` Thierry Reding
2020-10-01 10:46       ` Thierry Reding
2020-10-02  1:29         ` Nicolin Chen
2020-09-30  8:42 ` [PATCH v3 3/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-09-30 14:53   ` Dmitry Osipenko
2020-09-30 20:03     ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJKOXPfbCRDY7TUZ4HXphrd6boWYEKb_DMOxth3ucPTB2UCUtw@mail.gmail.com \
    --to=krzk@kernel.org \
    --cc=digetx@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).