From: Michael Kelley via iommu <iommu@lists.linux-foundation.org>
To: boqun.feng <boqun.feng@gmail.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "boqun.feng" <boqun.feng@gmail.com>,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>
Subject: RE: [PATCH] drivers: iommu: hyperv: Make HYPERV_IOMMU only available on x86
Date: Thu, 17 Oct 2019 23:31:13 +0000 [thread overview]
Message-ID: <DM5PR21MB01372A106600DBCC137EAF30D76D0@DM5PR21MB0137.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20191017005711.2013647-1-boqun.feng@gmail.com>
From: Boqun Feng <boqun.feng@gmail.com> Sent: Wednesday, October 16, 2019 5:57 PM
>
> Currently hyperv-iommu is implemented in a x86 specific way, for
> example, apic is used. So make the HYPERV_IOMMU Kconfig depend on X86
> as a preparation for enabling HyperV on architecture other than x86.
>
> Cc: Lan Tianyu <Tianyu.Lan@microsoft.com>
> Cc: Michael Kelley <mikelley@microsoft.com>
> Cc: linux-hyperv@vger.kernel.org
> Signed-off-by: Boqun Feng (Microsoft) <boqun.feng@gmail.com>
> ---
>
> Without this patch, I could observe compile error:
>
> | drivers/iommu/hyperv-iommu.c:17:10: fatal error: asm/apic.h: No such
> | file or directory
> | 17 | #include <asm/apic.h>
> | | ^~~~~~~~~~~~
>
> , after apply Michael's ARM64 on HyperV enablement patchset.
>
> drivers/iommu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index e3842eabcfdd..f1086eaed41c 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -467,7 +467,7 @@ config QCOM_IOMMU
>
> config HYPERV_IOMMU
> bool "Hyper-V x2APIC IRQ Handling"
> - depends on HYPERV
> + depends on HYPERV && X86
> select IOMMU_API
> default HYPERV
> help
> --
> 2.23.0
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-10-17 23:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 0:57 [PATCH] drivers: iommu: hyperv: Make HYPERV_IOMMU only available on x86 Boqun Feng
2019-10-17 23:31 ` Michael Kelley via iommu [this message]
2019-10-28 16:20 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR21MB01372A106600DBCC137EAF30D76D0@DM5PR21MB0137.namprd21.prod.outlook.com \
--to=iommu@lists.linux-foundation.org \
--cc=Tianyu.Lan@microsoft.com \
--cc=boqun.feng@gmail.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).