archive mirror
 help / color / mirror / Atom feed
From: Frank Wunderlich <>
To: Joerg Roedel <>
Cc:, Will Deacon <>,,
	Frank Wunderlich <>
Subject: Re: [PATCH] iommu: check if group is NULL before remove device
Date: Wed, 28 Jul 2021 12:35:07 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <YO/>

Hi Joerg,

Sorry for late reply, somehow i marked message as read without answering it.

Am 15. Juli 2021 09:20:04 MESZ schrieb Joerg Roedel <>:
>On Thu, Jul 15, 2021 at 09:11:50AM +0200, Frank Wunderlich wrote:
>> From: Frank Wunderlich <>
>> if probe is failing, iommu_group may be not initialized,
>Sentences start with capital letters.
>IOMMU patch subjects too, after the 'iommu:' prefix.

Will fix these in v2

>> so freeing it will result in NULL pointer access
>Please describe in more detail how this NULL-ptr dereference is

I had this by testing this series:

Initialization in mtk driver was failed (i guess the iommu group was not yet created), cleanup was started and so this function is called with a NULL group pointer. I can try to find my debug-trace if you need a kind of backtrace.

regards Frank
iommu mailing list

  reply	other threads:[~2021-07-28 10:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15  7:11 [PATCH] iommu: check if group is NULL before remove device Frank Wunderlich
2021-07-15  7:20 ` Joerg Roedel
2021-07-28 10:35   ` Frank Wunderlich [this message]
2021-07-30 13:18   ` Frank Wunderlich (linux)
  -- strict thread matches above, loose matches on Subject: below --
2021-07-15  7:10 Frank Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).