iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Wen Yang <yellowriver2010-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
To: Laurent Pinchart
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	"joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org"
	<joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	Laurent Pinchart
	<laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	Magnus Damm
	<damm+renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] iommu/ipmmu-vmsa: fix device reference leaks
Date: Fri, 15 Feb 2019 13:20:41 +0000	[thread overview]
Message-ID: <HK0PR02MB36344C466562FC3DBD34E903B2600@HK0PR02MB3634.apcprd02.prod.outlook.com> (raw)
In-Reply-To: <20190212164722.GT6279-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org>

Hi 
> > > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> > > index 7a4529c..cebf56d 100644
> > > --- a/drivers/iommu/ipmmu-vmsa.c
> > > +++ b/drivers/iommu/ipmmu-vmsa.c
> > > @@ -756,6 +756,9 @@ static int ipmmu_init_platform_device(struct device *dev,
> > >
> > >     fwspec->iommu_priv = platform_get_drvdata(ipmmu_pdev);
> > >
> > > +   if (!fwspec->iommu_priv)
> > > +           put_device(&ipmmu_pdev->dev);
> > > +
> 
> This doesn't seem to match the patch's subject, and doesn't seem to fix
> the problem.

Thanks for your comments.
I will submit a v2 patch later.
Thank you.

Regards,

Wen

      parent reply	other threads:[~2019-02-15 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-03 10:27 [PATCH] iommu/ipmmu-vmsa: fix device reference leaks wen yang
2019-02-11 10:24 ` joro
2019-02-12 16:47   ` Laurent Pinchart
     [not found]     ` <20190212164722.GT6279-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org>
2019-02-15 13:20       ` Wen Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HK0PR02MB36344C466562FC3DBD34E903B2600@HK0PR02MB3634.apcprd02.prod.outlook.com \
    --to=yellowriver2010-pkbjnfxxiarbdgjk7y7tuq@public.gmane.org \
    --cc=damm+renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).